You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by ga...@apache.org on 2026/10/22 07:10:48 UTC

(doris) branch master updated: [fix](regression) retry uncompacted tablets in test_fix_tablet_stat_fault_injection (#67723)

This is an automated email from the ASF dual-hosted git repository.

gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 59dd412670e [fix](regression) retry uncompacted tablets in test_fix_tablet_stat_fault_injection (#67723)
59dd412670e is described below

commit 59dd412670e907e73d2ab8b067f41d933f50d4be
Author: Jamie <li...@selectdb.com>
AuthorDate: Thu Oct 22 15:10:39 2026 +0800

    [fix](regression) retry uncompacted tablets in test_fix_tablet_stat_fault_injection (#67723)
---
 .../test_fix_tablet_stat_fault_injection.groovy    | 35 ++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

diff --git a/regression-test/suites/fault_injection_p0/test_fix_tablet_stat_fault_injection.groovy b/regression-test/suites/fault_injection_p0/test_fix_tablet_stat_fault_injection.groovy
index cc248522a27..eff86b85420 100644
--- a/regression-test/suites/fault_injection_p0/test_fix_tablet_stat_fault_injection.groovy
+++ b/regression-test/suites/fault_injection_p0/test_fix_tablet_stat_fault_injection.groovy
@@ -82,10 +82,36 @@ suite("test_fix_tablet_stat_fault_injection", "nonConcurrent") {
 
                 // trigger full compactions for all tablets in ${tableName}
                 trigger_and_wait_compaction(tableName, "full")
+                // In cloud mode the compaction trigger is asynchronous and trigger_and_wait_compaction
+                // returns once every tablet reports a completion timestamp, no matter whether the
+                // compaction succeeded or failed. With 1000 full compactions on one MoW table a few
+                // of them may fail with a transient delete bitmap lock conflict
+                // (DELETE_BITMAP_LOCK_ERROR) after the meta-service retry budget is exhausted. Such a
+                // tablet keeps its original rowsets and misses one injected size delta, which breaks
+                // the SHOW DATA golden below. Re-trigger only the tablets that are still uncompacted.
+                def uncompactedTablets = { ->
+                    tablets.findAll { tablet ->
+                        def (code, out, err) = curl("GET", tablet.CompactionStatus)
+                        assertEquals(code, 0)
+                        def tabletJson = parseJson(out.trim())
+                        assert tabletJson.rowsets instanceof List
+                        // a compacted tablet only holds [0-1] and the compacted [2-6] rowset
+                        ((List<String>) tabletJson.rowsets).size() != 2
+                    }
+                }
+                for (int round = 1; round <= 5; round++) {
+                    def pending = uncompactedTablets()
+                    if (pending.isEmpty()) {
+                        break
+                    }
+                    logger.info("round ${round}: re-trigger full compaction for ${pending.size()} tablets: ${pending.collect { it.TabletId }}")
+                    trigger_and_wait_compaction(tableName, "full", 300, [] as String[], pending.collect { it.TabletId })
+                }
 
                 sleep(60000)
                 // after full compaction, there are 2 rowsets.
                 rowsetCount = 0
+                def notCompacted = []
                 for (def tablet in tablets) {
                     String tablet_id = tablet.TabletId
                     def (code, out, err) = curl("GET", tablet.CompactionStatus)
@@ -93,9 +119,14 @@ suite("test_fix_tablet_stat_fault_injection", "nonConcurrent") {
                     assertEquals(code, 0)
                     def tabletJson = parseJson(out.trim())
                     assert tabletJson.rowsets instanceof List
-                    rowsetCount +=((List<String>) tabletJson.rowsets).size()
+                    def rowsets = (List<String>) tabletJson.rowsets
+                    rowsetCount += rowsets.size()
+                    if (rowsets.size() != 2) {
+                        notCompacted.add("tablet_id=${tablet_id} rowsets=${rowsets.size()} last_full_status=${tabletJson['last full status']}")
+                    }
                 }
-                // assert (rowsetCount == 2 * bucketSize * partitionSize)
+                assert notCompacted.isEmpty() : "full compaction did not finish on ${notCompacted.size()} tablets: ${notCompacted}"
+                assert (rowsetCount == 2 * bucketSize * partitionSize)
 
                 // data size should be very large
                 sql "select count(*) from ${tableName};"


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org