You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/04 01:59:35 UTC

Review Request 31714: Suppress empty RPC response logging from the client.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31714/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
-------

The client used to log an empty line for every successful RPC.  This make the client much less noisy.


Diffs
-----

  src/main/python/apache/aurora/client/cli/context.py d3113ff693eb87be3ec383f238b204f4f4b411c4 

Diff: https://reviews.apache.org/r/31714/diff/


Testing
-------

Ran end-to-end tests, output is more sane.


Thanks,

Bill Farner


Re: Review Request 31714: Suppress empty RPC response logging from the client.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31714/#review75123
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On March 3, 2015, 4:59 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31714/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 4:59 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The client used to log an empty line for every successful RPC.  This make the client much less noisy.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py d3113ff693eb87be3ec383f238b204f4f4b411c4 
> 
> Diff: https://reviews.apache.org/r/31714/diff/
> 
> 
> Testing
> -------
> 
> Ran end-to-end tests, output is more sane.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 31714: Suppress empty RPC response logging from the client.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31714/#review75126
-----------------------------------------------------------


Master (270faf7) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 4, 2015, 12:59 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31714/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 12:59 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The client used to log an empty line for every successful RPC.  This make the client much less noisy.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py d3113ff693eb87be3ec383f238b204f4f4b411c4 
> 
> Diff: https://reviews.apache.org/r/31714/diff/
> 
> 
> Testing
> -------
> 
> Ran end-to-end tests, output is more sane.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>