You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/09/29 11:59:31 UTC
[PR] Fixed: Six regressions in the minilang-to-Groovy conversion of ProductServicesScript.groovy (OFBIZ-13621) [ofbiz-framework]
mridulpathak opened a new pull request, #2143:
URL: https://github.com/apache/ofbiz-framework/pull/2143
- deleteProductGroupOrder() always threw: it called removeRelated('OrderItemGroupOrder'), a relation that doesn't exist on ProductGroupOrder, and removed the parent row before its children. Now removes OrderItemGroupOrder rows first, then the parent.
- checkProductRelatedPermission() dropped the product's category-membership date filter, since a second filterByDate() call replaced rather than added to the first. A limited-admin could retain permission via an expired category membership.
- forceIndexProductKeywords() and deleteProductKeywords() added .cache() to their Product lookup, not present in the original mini-lang.
- cancleOrderItemGroupOrder() treated a legitimate cancelQuantity of zero as unset due to Groovy's truthiness on BigDecimal.
- updateProductQuickAdminName() passed the wrong method-name string to its permission check, producing a misleading error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Six regressions in the minilang-to-Groovy conversion of ProductServicesScript.groovy (OFBIZ-13621) [ofbiz-framework]
Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #2143:
URL: https://github.com/apache/ofbiz-framework/pull/2143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org