You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Anna Szonyi via Review Board <no...@reviews.apache.org> on 2018/03/19 13:55:57 UTC
Review Request 66067: SQOOP-3052: Introduce gradle-based build for
Sqoop to make it more developer friendly / open
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs
-----
.gitignore 68cbe28
COMPILING.txt 86be509
build.gradle PRE-CREATION
buildSrc/customUnixStartScript.txt PRE-CREATION
buildSrc/customWindowsStartScript.txt PRE-CREATION
buildSrc/sqoop-package.gradle PRE-CREATION
buildSrc/sqoop-version-gen.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/66067/diff/1/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 23, 2018, 4:33 p.m., Szabolcs Vasas wrote:
> > Hi Anna,
> >
> > Awesome, thanks for the quick update.
> >
> > I have tried running the third party tests today, it was successful, however there is a small problem with the cleanup.
> > If I run ./gradlew test first and then the third party tests then org.apache.sqoop.manager.sqlserver.SQLServerHiveImportTest.testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema fails. This test case succeeds if I run the third party tests only after a ./gradlew clean. I think the problem is that SQLServerHiveImportTest extends HiveImportTest which does not do a proper Hive metastore database cleanup, so a table which has to be created by the test already exists.
> > Anyway, changing the Hive metastore DB to an in-memory DB solves the problem so I think can incorporate it into your patch (https://github.com/szvasas/sqoop/blob/gradletest2/testdata/hcatalog/conf/hive-site.xml#L37). I am not sure why but I did not experience this issue when running the tests with ant.
> >
> > An interesting thing I have noticed is that when I try to execute one test case Gradle seems to start up lots of JVMs even after the test has successfully finished.
> >
> > ./gradlew test --tests org.apache.sqoop.hive.TestHiveImport
> > :test
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[10180]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[10183]: Class JavaLaunchHelper is implemented in both
> > ...
> > ...
> > ...
> > ...
> >
> > org.apache.sqoop.hive.TestHiveImport > testDecimalMapColumnHive STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testDecimalMapColumnHive PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelims STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelims PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testGenerateOnly STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testGenerateOnly PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveExitFails STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveExitFails PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testDate STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testDate PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelimsReplacement STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelimsReplacement PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCustomDelimiters STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCustomDelimiters PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveDropAndReplaceOptionValidation STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveDropAndReplaceOptionValidation PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImport STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImport PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOnlyHiveImport STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOnlyHiveImport PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testAppendHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testAppendHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImport STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImport PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportWithBadPartitionKey STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportWithBadPartitionKey PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportHiveWithPartitions STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportHiveWithPartitions PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNumeric STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNumeric PASSED
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[11118]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[11119]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> > ...
> > ...
> >
> > BUILD SUCCESSFUL
> >
> > Total time: 2 mins 54.654 secs
> >
> >
> > I am not sure what happens here, my guess is that a new JVM is started for every test case even if they are not executed. Have you experienced this problem too?
I've had similar issues running with the --tests option, I usually use -Dtest.single, unfortunately if you have a buildSrc folder in your project that seems to mess everything up for test.single, so I can rename that directory to solve this for now. Oddly enough it doesn't affect thirdParty.single.
Maybe in the long run we can also try to make test runs independent, so we don't have to use forkevery 1...
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199896
-----------------------------------------------------------
On March 23, 2018, 10:28 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 3b82250
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/6/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 23, 2018, 4:33 p.m., Szabolcs Vasas wrote:
> > Hi Anna,
> >
> > Awesome, thanks for the quick update.
> >
> > I have tried running the third party tests today, it was successful, however there is a small problem with the cleanup.
> > If I run ./gradlew test first and then the third party tests then org.apache.sqoop.manager.sqlserver.SQLServerHiveImportTest.testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema fails. This test case succeeds if I run the third party tests only after a ./gradlew clean. I think the problem is that SQLServerHiveImportTest extends HiveImportTest which does not do a proper Hive metastore database cleanup, so a table which has to be created by the test already exists.
> > Anyway, changing the Hive metastore DB to an in-memory DB solves the problem so I think can incorporate it into your patch (https://github.com/szvasas/sqoop/blob/gradletest2/testdata/hcatalog/conf/hive-site.xml#L37). I am not sure why but I did not experience this issue when running the tests with ant.
> >
> > An interesting thing I have noticed is that when I try to execute one test case Gradle seems to start up lots of JVMs even after the test has successfully finished.
> >
> > ./gradlew test --tests org.apache.sqoop.hive.TestHiveImport
> > :test
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[10180]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[10183]: Class JavaLaunchHelper is implemented in both
> > ...
> > ...
> > ...
> > ...
> >
> > org.apache.sqoop.hive.TestHiveImport > testDecimalMapColumnHive STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testDecimalMapColumnHive PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelims STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelims PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testGenerateOnly STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testGenerateOnly PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveExitFails STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveExitFails PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testDate STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testDate PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelimsReplacement STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelimsReplacement PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCustomDelimiters STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCustomDelimiters PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveDropAndReplaceOptionValidation STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveDropAndReplaceOptionValidation PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImport STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImport PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOnlyHiveImport STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOnlyHiveImport PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testAppendHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testAppendHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImport STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImport PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNormalHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportWithBadPartitionKey STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportWithBadPartitionKey PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImportAsParquet STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImportAsParquet PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportHiveWithPartitions STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testImportHiveWithPartitions PASSED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNumeric STARTED
> >
> > org.apache.sqoop.hive.TestHiveImport > testNumeric PASSED
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[11118]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
> > objc[11119]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> > ...
> > ...
> >
> > BUILD SUCCESSFUL
> >
> > Total time: 2 mins 54.654 secs
> >
> >
> > I am not sure what happens here, my guess is that a new JVM is started for every test case even if they are not executed. Have you experienced this problem too?
>
> Anna Szonyi wrote:
> I've had similar issues running with the --tests option, I usually use -Dtest.single, unfortunately if you have a buildSrc folder in your project that seems to mess everything up for test.single, so I can rename that directory to solve this for now. Oddly enough it doesn't affect thirdParty.single.
> Maybe in the long run we can also try to make test runs independent, so we don't have to use forkevery 1...
Hey Szabi,
Please try with test.single with the new patch - you shouldn't face the same issues!
Thanks,
Anna
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199896
-----------------------------------------------------------
On April 13, 2018, 9:06 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 13, 2018, 9:06 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
>
>
> Diff: https://reviews.apache.org/r/66067/diff/7/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199896
-----------------------------------------------------------
Hi Anna,
Awesome, thanks for the quick update.
I have tried running the third party tests today, it was successful, however there is a small problem with the cleanup.
If I run ./gradlew test first and then the third party tests then org.apache.sqoop.manager.sqlserver.SQLServerHiveImportTest.testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema fails. This test case succeeds if I run the third party tests only after a ./gradlew clean. I think the problem is that SQLServerHiveImportTest extends HiveImportTest which does not do a proper Hive metastore database cleanup, so a table which has to be created by the test already exists.
Anyway, changing the Hive metastore DB to an in-memory DB solves the problem so I think can incorporate it into your patch (https://github.com/szvasas/sqoop/blob/gradletest2/testdata/hcatalog/conf/hive-site.xml#L37). I am not sure why but I did not experience this issue when running the tests with ant.
An interesting thing I have noticed is that when I try to execute one test case Gradle seems to start up lots of JVMs even after the test has successfully finished.
./gradlew test --tests org.apache.sqoop.hive.TestHiveImport
:test
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
objc[10180]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
objc[10183]: Class JavaLaunchHelper is implemented in both
...
...
...
...
org.apache.sqoop.hive.TestHiveImport > testDecimalMapColumnHive STARTED
org.apache.sqoop.hive.TestHiveImport > testDecimalMapColumnHive PASSED
org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelims STARTED
org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelims PASSED
org.apache.sqoop.hive.TestHiveImport > testGenerateOnly STARTED
org.apache.sqoop.hive.TestHiveImport > testGenerateOnly PASSED
org.apache.sqoop.hive.TestHiveImport > testHiveExitFails STARTED
org.apache.sqoop.hive.TestHiveImport > testHiveExitFails PASSED
org.apache.sqoop.hive.TestHiveImport > testDate STARTED
org.apache.sqoop.hive.TestHiveImport > testDate PASSED
org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelimsReplacement STARTED
org.apache.sqoop.hive.TestHiveImport > testFieldWithHiveDelimsReplacement PASSED
org.apache.sqoop.hive.TestHiveImport > testCustomDelimiters STARTED
org.apache.sqoop.hive.TestHiveImport > testCustomDelimiters PASSED
org.apache.sqoop.hive.TestHiveImport > testHiveDropAndReplaceOptionValidation STARTED
org.apache.sqoop.hive.TestHiveImport > testHiveDropAndReplaceOptionValidation PASSED
org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImport STARTED
org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImport PASSED
org.apache.sqoop.hive.TestHiveImport > testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema STARTED
org.apache.sqoop.hive.TestHiveImport > testHiveImportAsParquetWhenTableExistsWithIncompatibleSchema PASSED
org.apache.sqoop.hive.TestHiveImport > testCreateHiveImportAsParquet STARTED
org.apache.sqoop.hive.TestHiveImport > testCreateHiveImportAsParquet PASSED
org.apache.sqoop.hive.TestHiveImport > testCreateOnlyHiveImport STARTED
org.apache.sqoop.hive.TestHiveImport > testCreateOnlyHiveImport PASSED
org.apache.sqoop.hive.TestHiveImport > testAppendHiveImportAsParquet STARTED
org.apache.sqoop.hive.TestHiveImport > testAppendHiveImportAsParquet PASSED
org.apache.sqoop.hive.TestHiveImport > testNormalHiveImport STARTED
org.apache.sqoop.hive.TestHiveImport > testNormalHiveImport PASSED
org.apache.sqoop.hive.TestHiveImport > testNormalHiveImportAsParquet STARTED
org.apache.sqoop.hive.TestHiveImport > testNormalHiveImportAsParquet PASSED
org.apache.sqoop.hive.TestHiveImport > testImportWithBadPartitionKey STARTED
org.apache.sqoop.hive.TestHiveImport > testImportWithBadPartitionKey PASSED
org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImportAsParquet STARTED
org.apache.sqoop.hive.TestHiveImport > testCreateOverwriteHiveImportAsParquet PASSED
org.apache.sqoop.hive.TestHiveImport > testImportHiveWithPartitions STARTED
org.apache.sqoop.hive.TestHiveImport > testImportHiveWithPartitions PASSED
org.apache.sqoop.hive.TestHiveImport > testNumeric STARTED
org.apache.sqoop.hive.TestHiveImport > testNumeric PASSED
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
objc[11118]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
objc[11119]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
...
...
BUILD SUCCESSFUL
Total time: 2 mins 54.654 secs
I am not sure what happens here, my guess is that a new JVM is started for every test case even if they are not executed. Have you experienced this problem too?
- Szabolcs Vasas
On March 23, 2018, 10:28 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 3b82250
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/6/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 25, 2018, 7:15 p.m., Boglarka Egyed wrote:
> > Hi Anna,
> >
> > I did some deeper testing with your change and found that the number of run 3rd party test cases in case of ant and gradle are different: 782 test cases run with ant but only 595 with gradle. I didn't check all the details but for example with ant 71 test cases runs in SQLServerDatatypeImportSequenceFileTest test class but 0 with gradle. Could you please check this?
> >
> > I also have some minor comments again.
> >
> > Otherwise your change looks very good in general, huge thanks for preparing this patch!
> >
> > Many thanks,
> > Bogi
>
> daniel voros wrote:
> Hi,
>
> I can second Bogi. These are missing tests:
> ```
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeExportDelimitedFileTest
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeExportSequenceFileTest
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportDelimitedFileTest
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportSequenceFileTest
> ```
>
> They've all failed in their setup phase with similar errors:
>
> ```
> 2018-03-26 09:31:17,481 (Test worker) [ERROR - org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportSequenceFileTest.<clinit>(SQLServerDatatypeImportSequenceFileTest.java:88)] java.io.FileNotFoundException: /Users/dvoros/repos/sqoop-tmp/testdata/null (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.<init>(FileInputStream.java:138)
> at java.io.FileInputStream.<init>(FileInputStream.java:93)
> at java.io.FileReader.<init>(FileReader.java:58)
> at org.apache.sqoop.manager.sqlserver.MSSQLTestDataFileParser.parse(MSSQLTestDataFileParser.java:62)
> at org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportSequenceFileTest.<clinit>(SQLServerDatatypeImportSequenceFileTest.java:85)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
> at org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:147)
> at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:129)
> at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
> at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
> at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> ```
>
> I think they were relying on some system properties that we had defined in build.xml but not in build.gradle (e.g. ms.datatype.test.data.file.export).
>
> Other than that, results are the same, both for regular and third-party tests.
>
> Regards,
> Daniel
Hey guys,
Thanks for checking this I missed it. There are some missing sql server properties. I have added them and verified that they are now running.
Thanks,
Anna
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199930
-----------------------------------------------------------
On March 23, 2018, 10:28 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 3b82250
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/6/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199930
-----------------------------------------------------------
Hi Anna,
I did some deeper testing with your change and found that the number of run 3rd party test cases in case of ant and gradle are different: 782 test cases run with ant but only 595 with gradle. I didn't check all the details but for example with ant 71 test cases runs in SQLServerDatatypeImportSequenceFileTest test class but 0 with gradle. Could you please check this?
I also have some minor comments again.
Otherwise your change looks very good in general, huge thanks for preparing this patch!
Many thanks,
Bogi
COMPILING.txt
Lines 332-341 (patched)
<https://reviews.apache.org/r/66067/#comment280437>
Could you please separate these parts a bit more consistently? Now the title of this section is Cobertura however with gradle Jacoco would be used. Also, could you please mention here where the reports are generated?
build.gradle
Lines 143 (patched)
<https://reviews.apache.org/r/66067/#comment280435>
I might miss something but is this comment needed here?
- Boglarka Egyed
On March 23, 2018, 10:28 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 3b82250
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/6/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by daniel voros <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201990
-----------------------------------------------------------
Hey Anna,
Thank you for addressing my previous concerns! As a final touch I've tried to compare the contents of the tar.gz we're creating. I've used
```
ant tar
./gradlew tar
```
and ended up with the following differences (right side is gradle):
```
11a12
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-codegen.bat
12a14
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-create-hive-table.bat
13a16
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-eval.bat
14a18
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-export.bat
15a20
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-help.bat
17a23
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-import-all-tables.bat
18a25,26
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-import-mainframe.bat
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-import.bat
19a28
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-job.bat
20a30
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-list-databases.bat
21a32
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-list-tables.bat
22a34
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-merge.bat
23a36
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-metastore.bat
24a38
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/bin/sqoop-version.bat
72,88d85
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/BigDecimalSerializer.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/BlobRef.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/BooleanParser.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/ClobRef.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/DelimiterSet.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/FieldFormatter.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/FieldMapProcessor.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/FieldMappable.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/JdbcWritableBridge.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/LargeObjectLoader.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/LobRef.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/LobSerializer.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/ProcessingException.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/RecordParser.ParseError.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/RecordParser.html
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/class-use/SqoopRecord.html
92d88
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/docs/api/org/apache/sqoop/lib/package-use.html
163a160
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib/avro-ipc-1.8.1.jar
165c162
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib/commons-codec-1.4.jar
---
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib/commons-codec-1.9.jar
189a187
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib/parquet-hive-bundle-1.6.0.jar
191c189
< sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib/slf4j-api-1.6.1.jar
---
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib/slf4j-api-1.7.7.jar
342a341
> sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/src/java/org/apache/sqoop/SqoopVersion.java
```
These fall into the following four categories (in order):
1) Windows executables. There were some conditional parts in build.xml regarding windows. I don't see these in our [latest release](http://www-us.apache.org/dist/sqoop/1.4.7/sqoop-1.4.7.bin__hadoop-2.6.0.tar.gz). Shouldn't we just get rid of all these?
2) Javadoc used to include class usage info (see [here](https://github.com/apache/sqoop/blob/72c5cd717e3fad6d5f5a3a2b3d185ffbacd876cf/build.xml#L1096). I think the 'use' option does the same in gradle (see [here](https://docs.gradle.org/current/javadoc/org/gradle/external/javadoc/StandardJavadocDocletOptions.html#isUse--)).
3) Jar differences under `lib/`. This is what worries me the most. I've had trouble with having (wrong version of) `parquet-hive-bundle` on the classpath. I think we should try to make contents of lib/ the same. One difference I've spotted is that we're not excluding parquet-hive-bundle from kite as we [used to](https://github.com/apache/sqoop/blob/72c5cd717e3fad6d5f5a3a2b3d185ffbacd876cf/ivy.xml#L118).
4) SqoopVersion.java is now included. I think it makes sense to keep it. Any objections?
Regards,
Daniel
- daniel voros
On April 24, 2018, 2:23 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/10/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201925
-----------------------------------------------------------
Ship it!
Hi Anna,
Thank you for fixing everything, let's ship this! :)
Just for the record: I have noticed that gradle generates significantly bigger log files during test execution but this happens because it picks up the log4j.properties in the testdata folder which should be the expected behavior but ant did not seem to do it. I think we can think about changing the log level in that properties file but we can create another JIRA for that.
- Szabolcs Vasas
On April 24, 2018, 2:23 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/10/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review206335
-----------------------------------------------------------
Ship it!
Hi All,
As discussed offline I suggest committing this patch as it is now and address the above suggestions in separate commits.
I think it would be beneficial for the community to be able to start using the improved build infrastructure and since the ant build will remain in the project it is a low risk change.
Szabolcs
- Szabolcs Vasas
On April 24, 2018, 2:23 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/10/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review206336
-----------------------------------------------------------
Ship it!
Hi All,
I agree with Szabolcs, thanks for pushing this forward!
We can say that this is in experimental status and everyone is welcome to improve/correct as needed in further patches.
Regards,
Bogi
- Boglarka Egyed
On April 24, 2018, 2:23 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/10/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated April 24, 2018, 2:23 p.m.)
Review request for Sqoop.
Changes
-------
changed per Szabi's comments and regenerated with --binary per Fero's issue.
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28731e613607c208824443d1edf256d9c8a
COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
build.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/customUnixStartScript.txt PRE-CREATION
gradle/customWindowsStartScript.txt PRE-CREATION
gradle/sqoop-package.gradle PRE-CREATION
gradle/sqoop-version-gen.gradle PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
Diff: https://reviews.apache.org/r/66067/diff/10/
Changes: https://reviews.apache.org/r/66067/diff/9-10/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On April 23, 2018, 3:06 p.m., Szabolcs Vasas wrote:
> > Hi Anna,
> >
> > Thank you for fixing the HiveImportTest problem, it works fine now.
> > I have added a few more comments, there are a few test cases failing now because of SQOOP-3309 but it is easy to fix it.
> >
> > However relnotes and release tasks fail on my side are they supposed to work with some extra parameters?
Would you mind including the error message? It is supposed to skip this step in case the version is a SNAPSHOT version. If you specify -Pversion it should run (it should suceed in both cases, but skip execution in the snapshot case).
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201738
-----------------------------------------------------------
On April 24, 2018, 2:23 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/10/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201738
-----------------------------------------------------------
Hi Anna,
Thank you for fixing the HiveImportTest problem, it works fine now.
I have added a few more comments, there are a few test cases failing now because of SQOOP-3309 but it is easy to fix it.
However relnotes and release tasks fail on my side are they supposed to work with some extra parameters?
.gitignore
Lines 42 (patched)
<https://reviews.apache.org/r/66067/#comment283301>
When I execute a test case in IntelliJ a directory called out is created, can we add it to .gitignore?
build.gradle
Lines 110 (patched)
<https://reviews.apache.org/r/66067/#comment283298>
Since SQOOP-3309 we need another dependency here:
common group: 'org.apache.hive', name: 'hive-jdbc', version: hcatalogVersion
build.gradle
Lines 168 (patched)
<https://reviews.apache.org/r/66067/#comment283300>
Does not really matter but there is a typo here: hadooop
build.gradle
Lines 176 (patched)
<https://reviews.apache.org/r/66067/#comment283299>
HiveServer2 test cases added in SQOOP-3309 need an extra JVM arg here:
"-da:org.apache.hadoop.hive.thrift.HadoopThriftAuthBridge"
- Szabolcs Vasas
On April 23, 2018, 10:40 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:40 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/9/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
> On April 24, 2018, 12:24 p.m., Fero Szabo wrote:
> > build.gradle
> > Lines 349 (patched)
> > <https://reviews.apache.org/r/66067/diff/9/?file=2005487#file2005487line349>
> >
> > When running the docs task, I get 55 warnings and the BUILD FAILED message. Can you please fix it? (Should we just ignore the warnings?)
> >
> > Please get back to me, if you need the logs, I'll run it again.
There are warnings, but it's successful now, let's drop this issue
- Fero
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201828
-----------------------------------------------------------
On April 23, 2018, 10:40 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:40 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/9/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201828
-----------------------------------------------------------
build.gradle
Lines 349 (patched)
<https://reviews.apache.org/r/66067/#comment283424>
When running the docs task, I get 55 warnings and the BUILD FAILED message. Can you please fix it? (Should we just ignore the warnings?)
Please get back to me, if you need the logs, I'll run it again.
- Fero Szabo
On April 23, 2018, 10:40 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:40 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/9/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated April 23, 2018, 10:40 a.m.)
Review request for Sqoop.
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28731e613607c208824443d1edf256d9c8a
COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
build.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/customUnixStartScript.txt PRE-CREATION
gradle/customWindowsStartScript.txt PRE-CREATION
gradle/sqoop-package.gradle PRE-CREATION
gradle/sqoop-version-gen.gradle PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
Diff: https://reviews.apache.org/r/66067/diff/9/
Changes: https://reviews.apache.org/r/66067/diff/8-9/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On April 23, 2018, 10:33 a.m., Fero Szabo wrote:
> > Hi Anna,
> >
> > I couldn't apply the patch cleanly, I ran into the following error message:
> >
> > fero-MBP:sqoop ferencszabo$ git apply ~/Downloads/SQOOP-3052-5.patch
> > error: missing binary patch data for 'gradle/wrapper/gradle-wrapper.jar'
> > error: binary patch does not apply to 'gradle/wrapper/gradle-wrapper.jar'
> > error: gradle/wrapper/gradle-wrapper.jar: patch does not apply
> >
> > Managed to apply it with the following command:
> > patch -p1 -i ~/Downloads/SQOOP-3052-5.patch
> >
> > Also, gradle was missing from my system, so I had to install it and then gradle/wrapper/gradle-wrapper.jar was probably downloaded after I executed 'gradle wrapper' or './gradlew wrapper'
> >
> > I'm not sure how to fix these though. Did I go through the "correct" way to install gradle? Maybe I should have invoked './gradlew wrapper' right after applying the patch. Would that work without gradle installed on the system?
> >
> > Anyway thanks for the patch, it would be really cool to use gradle in Sqoop!
Hi Fero,
Thanks for testing, I haven't rebased to the latest version of trunk, which might be the reason it doesn't apply cleanly? I tested it when I created the patch on the current (at that time) trunk, but I will definitely double-check this.
The reason we are adding the gradle wrapper jar and the gradlew and gradlew.bat files is that you shouldn't have been required to separately install gradle - just execute ./gradlew wrapper.
Thanks,
Anna
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201727
-----------------------------------------------------------
On April 18, 2018, 3:10 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 3:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/9/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On April 23, 2018, 10:33 a.m., Fero Szabo wrote:
> > Hi Anna,
> >
> > I couldn't apply the patch cleanly, I ran into the following error message:
> >
> > fero-MBP:sqoop ferencszabo$ git apply ~/Downloads/SQOOP-3052-5.patch
> > error: missing binary patch data for 'gradle/wrapper/gradle-wrapper.jar'
> > error: binary patch does not apply to 'gradle/wrapper/gradle-wrapper.jar'
> > error: gradle/wrapper/gradle-wrapper.jar: patch does not apply
> >
> > Managed to apply it with the following command:
> > patch -p1 -i ~/Downloads/SQOOP-3052-5.patch
> >
> > Also, gradle was missing from my system, so I had to install it and then gradle/wrapper/gradle-wrapper.jar was probably downloaded after I executed 'gradle wrapper' or './gradlew wrapper'
> >
> > I'm not sure how to fix these though. Did I go through the "correct" way to install gradle? Maybe I should have invoked './gradlew wrapper' right after applying the patch. Would that work without gradle installed on the system?
> >
> > Anyway thanks for the patch, it would be really cool to use gradle in Sqoop!
>
> Anna Szonyi wrote:
> Hi Fero,
>
> Thanks for testing, I haven't rebased to the latest version of trunk, which might be the reason it doesn't apply cleanly? I tested it when I created the patch on the current (at that time) trunk, but I will definitely double-check this.
>
> The reason we are adding the gradle wrapper jar and the gradlew and gradlew.bat files is that you shouldn't have been required to separately install gradle - just execute ./gradlew wrapper.
>
> Thanks,
> Anna
I've regenerated the diff with the --binary flag as well, which seems to be the solution for your apply issues, the rest of the issues stem from this.
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201727
-----------------------------------------------------------
On April 24, 2018, 2:23 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/10/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review201727
-----------------------------------------------------------
Hi Anna,
I couldn't apply the patch cleanly, I ran into the following error message:
fero-MBP:sqoop ferencszabo$ git apply ~/Downloads/SQOOP-3052-5.patch
error: missing binary patch data for 'gradle/wrapper/gradle-wrapper.jar'
error: binary patch does not apply to 'gradle/wrapper/gradle-wrapper.jar'
error: gradle/wrapper/gradle-wrapper.jar: patch does not apply
Managed to apply it with the following command:
patch -p1 -i ~/Downloads/SQOOP-3052-5.patch
Also, gradle was missing from my system, so I had to install it and then gradle/wrapper/gradle-wrapper.jar was probably downloaded after I executed 'gradle wrapper' or './gradlew wrapper'
I'm not sure how to fix these though. Did I go through the "correct" way to install gradle? Maybe I should have invoked './gradlew wrapper' right after applying the patch. Would that work without gradle installed on the system?
Anyway thanks for the patch, it would be really cool to use gradle in Sqoop!
- Fero Szabo
On April 18, 2018, 3:10 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 3:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
> testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
>
>
> Diff: https://reviews.apache.org/r/66067/diff/8/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated April 18, 2018, 3:10 p.m.)
Review request for Sqoop.
Changes
-------
changed hive-site.xml to inmemorydb - to ensure that we can rerunt tests without having to clean, corrected release information.
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28731e613607c208824443d1edf256d9c8a
COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
build.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/customUnixStartScript.txt PRE-CREATION
gradle/customWindowsStartScript.txt PRE-CREATION
gradle/sqoop-package.gradle PRE-CREATION
gradle/sqoop-version-gen.gradle PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313
Diff: https://reviews.apache.org/r/66067/diff/8/
Changes: https://reviews.apache.org/r/66067/diff/7-8/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated April 13, 2018, 9:06 a.m.)
Review request for Sqoop.
Changes
-------
Changes based on review feedback
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28731e613607c208824443d1edf256d9c8a
COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
build.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/customUnixStartScript.txt PRE-CREATION
gradle/customWindowsStartScript.txt PRE-CREATION
gradle/sqoop-package.gradle PRE-CREATION
gradle/sqoop-version-gen.gradle PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
Diff: https://reviews.apache.org/r/66067/diff/7/
Changes: https://reviews.apache.org/r/66067/diff/6-7/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 28, 2018, 11:02 a.m., daniel voros wrote:
> > Hey Anna,
> >
> > I've experimented with running the gradle build in a clean dockerized environment and found some minor issues:
> > 1) All dependencies are downloaded from jcenter, despite having central repository defined in build.gradle. This might be a result of my current setup, could you please confirm?
> > 2) Deprecation warnings for '<<' task doLast syntax ("Deprecation warning: The Task.leftShift(Closure) method has been deprecated...")
> > 3) SqoopVersion.java generation happens during task definition and not in action (missing doLast?).
> > 4) `relnotes` task fails if version is SNAPSHOT with: "A problem occurred starting process 'command 'cd''".
> > 5) The `release` task prints the path of tar and rat report but they're incorrect. (I've specified version on the command line with "-Pversion=1.5.0")
> > 6) `ant releaseaudit` now lists gradle files as errors
> >
> > I've corrected 2,3,4,5,6 in this commit: https://github.com/dvoros/sqoop/commit/47e361829b1004bdedd6f5c223332e3fb8b85696
> >
> > What's the reasoning behind using Gradle 3.5.1? Shouldn't we use 4.x? (I've successfully executed a simple build with 4.6)
> >
> > Regards,
> > Daniel
Hi Daniel,
Thanks for testing and the suggestions, I've incorporated your feedback!
Wrt gradle 3.5.1: for myself and some of the people testing this on their local machine tests weren't running with gradle 4.x+ and the fix wasn't trivial, so we decided to nail it down to 3.5 and increase it later, as it will probably result in code change as well.
#1 it uses jcenter for me as well by default, it might be because jcenter became the new default for gradle, as far as I can tell for the following reasons: https://blog.bintray.com/2015/02/09/android-studio-migration-from-maven-central-to-jcenter/, though tbh this isn't the expected behaviour - does everyone else experience this also?
#2 Oddly enough it behaves slightly differently for me, but not as significantly as --tests and test.single so I changed them all
#3 I've added doLast, but it doesn't change the order, not sure if it's worth further investigation.
#5 I missed this, I will correct it, thanks!
Thanks,
Anna
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review200102
-----------------------------------------------------------
On April 13, 2018, 9:06 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 13, 2018, 9:06 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
>
>
> Diff: https://reviews.apache.org/r/66067/diff/7/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by daniel voros <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review200102
-----------------------------------------------------------
Hey Anna,
I've experimented with running the gradle build in a clean dockerized environment and found some minor issues:
1) All dependencies are downloaded from jcenter, despite having central repository defined in build.gradle. This might be a result of my current setup, could you please confirm?
2) Deprecation warnings for '<<' task doLast syntax ("Deprecation warning: The Task.leftShift(Closure) method has been deprecated...")
3) SqoopVersion.java generation happens during task definition and not in action (missing doLast?).
4) `relnotes` task fails if version is SNAPSHOT with: "A problem occurred starting process 'command 'cd''".
5) The `release` task prints the path of tar and rat report but they're incorrect. (I've specified version on the command line with "-Pversion=1.5.0")
6) `ant releaseaudit` now lists gradle files as errors
I've corrected 2,3,4,5,6 in this commit: https://github.com/dvoros/sqoop/commit/47e361829b1004bdedd6f5c223332e3fb8b85696
What's the reasoning behind using Gradle 3.5.1? Shouldn't we use 4.x? (I've successfully executed a simple build with 4.6)
Regards,
Daniel
- daniel voros
On March 23, 2018, 10:28 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 3b82250
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/6/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated March 23, 2018, 10:28 a.m.)
Review request for Sqoop.
Changes
-------
Apologies for the barrage of changes - fixed messed up diff
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28
COMPILING.txt 3b82250
build.gradle PRE-CREATION
buildSrc/customUnixStartScript.txt PRE-CREATION
buildSrc/customWindowsStartScript.txt PRE-CREATION
buildSrc/sqoop-package.gradle PRE-CREATION
buildSrc/sqoop-version-gen.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/66067/diff/6/
Changes: https://reviews.apache.org/r/66067/diff/5-6/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated March 23, 2018, 10:19 a.m.)
Review request for Sqoop.
Changes
-------
Fixed diff vs. trunk
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28
COMPILING.txt 3b82250
src/docs/user/import.txt e91a5a8
Diff: https://reviews.apache.org/r/66067/diff/5/
Changes: https://reviews.apache.org/r/66067/diff/4-5/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated March 23, 2018, 10:05 a.m.)
Review request for Sqoop.
Changes
-------
ran the diff with diff-index --binary
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28
COMPILING.txt 86be509
build.gradle PRE-CREATION
buildSrc/customUnixStartScript.txt PRE-CREATION
buildSrc/customWindowsStartScript.txt PRE-CREATION
buildSrc/sqoop-package.gradle PRE-CREATION
buildSrc/sqoop-version-gen.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/66067/diff/4/
Changes: https://reviews.apache.org/r/66067/diff/3-4/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 23, 2018, 9:39 a.m., Szabolcs Vasas wrote:
> > Hi Anna,
> >
> > Thank you for replying so quickly!
> > The changes look good in RB but I could no apply it in my repo, I get the following error:
> >
> > error: patch failed: COMPILING.txt:403
> > error: COMPILING.txt: patch does not apply
> > error: cannot apply binary patch to 'gradle/wrapper/gradle-wrapper.jar' without full index line
> > error: gradle/wrapper/gradle-wrapper.jar: patch does not apply
Apologies, please try again. I ran the diff with diff-index --binary and it applies for me.
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199871
-----------------------------------------------------------
On March 23, 2018, 10:05 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 10:05 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/4/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199871
-----------------------------------------------------------
Hi Anna,
Thank you for replying so quickly!
The changes look good in RB but I could no apply it in my repo, I get the following error:
error: patch failed: COMPILING.txt:403
error: COMPILING.txt: patch does not apply
error: cannot apply binary patch to 'gradle/wrapper/gradle-wrapper.jar' without full index line
error: gradle/wrapper/gradle-wrapper.jar: patch does not apply
- Szabolcs Vasas
On March 22, 2018, 8:53 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 8:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/3/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated March 22, 2018, 8:53 p.m.)
Review request for Sqoop.
Changes
-------
added sourcecompatibilityversion, do not copy .gradle to packaging, gitignore .gradle
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28
COMPILING.txt 86be509
build.gradle PRE-CREATION
buildSrc/customUnixStartScript.txt PRE-CREATION
buildSrc/customWindowsStartScript.txt PRE-CREATION
buildSrc/sqoop-package.gradle PRE-CREATION
buildSrc/sqoop-version-gen.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/66067/diff/3/
Changes: https://reviews.apache.org/r/66067/diff/2-3/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------
(Updated March 22, 2018, 6:32 p.m.)
Review request for Sqoop.
Changes
-------
changed per Bogi's comment + added the missing gradle/gradle-wrapper.jar
Bugs: Sqoop-3052
https://issues.apache.org/jira/browse/Sqoop-3052
Repository: sqoop-trunk
Description
-------
SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
Diffs (updated)
-----
.gitignore 68cbe28
COMPILING.txt 86be509
build.gradle PRE-CREATION
buildSrc/customUnixStartScript.txt PRE-CREATION
buildSrc/customWindowsStartScript.txt PRE-CREATION
buildSrc/sqoop-package.gradle PRE-CREATION
buildSrc/sqoop-version-gen.gradle PRE-CREATION
config/checkstyle/checkstyle-java-header.txt PRE-CREATION
config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
config/checkstyle/checkstyle.xml PRE-CREATION
gradle.properties PRE-CREATION
gradle/wrapper/gradle-wrapper.jar PRE-CREATION
gradle/wrapper/gradle-wrapper.properties PRE-CREATION
gradlew PRE-CREATION
gradlew.bat PRE-CREATION
settings.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/66067/diff/2/
Changes: https://reviews.apache.org/r/66067/diff/1-2/
Testing
-------
ran all new tasks, except for internal maven publishing
Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
Thanks,
Anna Szonyi
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 22, 2018, 4:19 p.m., Boglarka Egyed wrote:
> > gradlew
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/66067/diff/1/?file=1982323#file1982323line1>
> >
> > License information header is missing from this file.
I don't think we can add the license header to this file, as it's the auto generated gradle "runner" file.
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199766
-----------------------------------------------------------
On March 22, 2018, 6:32 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 6:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/2/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
> On March 22, 2018, 4:19 p.m., Boglarka Egyed wrote:
> > Hi Anna,
> >
> > This is a superb improvement in Sqoop, many thanks for taking this huge effort! Using Gradle would indeed ease the life of the developers as well as let more enhancements to come in the future.
> >
> > However I was not able to apply your patch, I got the following error message:
> >
> > error: patch failed: COMPILING.txt:403
> > error: COMPILING.txt: patch does not apply
> > /Users/boglarka.egyed/Downloads/SQOOP-3052.patch:1178: new blank line at EOF.
> >
> > Could you please update the patch file?
> >
> > I also took a first glance and found some minor things, please find them below.
> >
> > Many thanks,
> > Bogi
Hi Bogi, Anna,
This is possibly coming from my patch, as I edited compiling.txt. https://reviews.apache.org/r/66062/
Though reviewboard doesn't show it, so I'm a bit puzzled. Also, my patch probably applied without problems.
- Fero
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199766
-----------------------------------------------------------
On March 19, 2018, 1:55 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 1:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/1/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199766
-----------------------------------------------------------
Hi Anna,
This is a superb improvement in Sqoop, many thanks for taking this huge effort! Using Gradle would indeed ease the life of the developers as well as let more enhancements to come in the future.
However I was not able to apply your patch, I got the following error message:
error: patch failed: COMPILING.txt:403
error: COMPILING.txt: patch does not apply
/Users/boglarka.egyed/Downloads/SQOOP-3052.patch:1178: new blank line at EOF.
Could you please update the patch file?
I also took a first glance and found some minor things, please find them below.
Many thanks,
Bogi
COMPILING.txt
Lines 206 (patched)
<https://reviews.apache.org/r/66067/#comment280211>
Typo: gralew
COMPILING.txt
Lines 215 (patched)
<https://reviews.apache.org/r/66067/#comment280212>
Typo: gralew
gradlew
Lines 1 (patched)
<https://reviews.apache.org/r/66067/#comment280213>
License information header is missing from this file.
- Boglarka Egyed
On March 19, 2018, 1:55 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 1:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/1/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Anna Szonyi via Review Board <no...@reviews.apache.org>.
> On March 22, 2018, 6:29 p.m., Szabolcs Vasas wrote:
> > Hi Anna,
> >
> > Thank you for the patch, it makes the contribution much easier!
> > I will continue my review tomorrow, I just wanted to post the findings from today.
> >
> > 1) The gradle wrapper script does not find the gradle-wrapper.jar, can you please add it to the patch as well (https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html)?
> > 2) Once the gradle-wrapper.jar is present the ./gradlew test runs successfully
> > 3) The project can be imported to IntelliJ without any problems
> > 4) I think a couple of more items should be added to .gitignore
> > .gradle/ -> I think this is generated by the gradle wrapper
> > out/ -> I am not sure why but when I import the project to IntelliJ and run a test from there it generates the out folder which was not present with the ant build
> > 5) Can we define the sourceCompatibility in build.gradle to say that we support 1.7 currently?
> > 6) I have executed the package target with both ant and gradle and I found some differences, can you please check that these are expected?
> > In case of gradle build bat files are also generated for sqoop tools scripts.
> > The .gradle folder is copied to build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0, I am not sure this is desired.
> > Some library versions are different in case of ant and gradle build.
> >
> > I am posting the relevant lines from the diff output:
> > Only in buildgradle/bin: sqoop-codegen.bat
> > Only in buildgradle/bin: sqoop-create-hive-table.bat
> > Only in buildgradle/bin: sqoop-eval.bat
> > Only in buildgradle/bin: sqoop-export.bat
> > Only in buildgradle/bin: sqoop-help.bat
> > Only in buildgradle/bin: sqoop-import-all-tables.bat
> > Only in buildgradle/bin: sqoop-import-mainframe.bat
> > Only in buildgradle/bin: sqoop-import.bat
> > Only in buildgradle/bin: sqoop-job.bat
> > Only in buildgradle/bin: sqoop-list-databases.bat
> > Only in buildgradle/bin: sqoop-list-tables.bat
> > Only in buildgradle/bin: sqoop-merge.bat
> > Only in buildgradle/bin: sqoop-metastore.bat
> > Only in buildgradle/bin: sqoop-version.bat
> > Only in build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1: file-changes
> > Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/fileContent/fileContent.lock and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/fileContent/fileContent.lock differ
> > Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileHashes.bin and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileHashes.bin differ
> > Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileSnapshots.bin and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileSnapshots.bin differ
> > Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.bin and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.bin differ
> > Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.lock and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.lock differ
> > Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: avro-ipc-1.8.1.jar
> > Only in build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: commons-codec-1.4.jar
> > Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: commons-codec-1.9.jar
> > Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: parquet-hive-bundle-1.6.0.jar
> > Only in build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: slf4j-api-1.6.1.jar
> > Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: slf4j-api-1.7.7.jar
Hi Szabi,
1) I've added that with my previous update
2) cool :)
3) cool cool :)
4) I will add it, as for the out folder, it doesn't generate that for me when running the test, not sure what that is
5) sure, will add!
6) The version differences are expected (it used to be hardcoded versions that were independent of the used version), but I agree the .gradle folder should not be copied.
I'll update the patch based on this.
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199660
-----------------------------------------------------------
On March 22, 2018, 6:32 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 6:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/2/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build
for Sqoop to make it more developer friendly / open
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review199660
-----------------------------------------------------------
Hi Anna,
Thank you for the patch, it makes the contribution much easier!
I will continue my review tomorrow, I just wanted to post the findings from today.
1) The gradle wrapper script does not find the gradle-wrapper.jar, can you please add it to the patch as well (https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html)?
2) Once the gradle-wrapper.jar is present the ./gradlew test runs successfully
3) The project can be imported to IntelliJ without any problems
4) I think a couple of more items should be added to .gitignore
.gradle/ -> I think this is generated by the gradle wrapper
out/ -> I am not sure why but when I import the project to IntelliJ and run a test from there it generates the out folder which was not present with the ant build
5) Can we define the sourceCompatibility in build.gradle to say that we support 1.7 currently?
6) I have executed the package target with both ant and gradle and I found some differences, can you please check that these are expected?
In case of gradle build bat files are also generated for sqoop tools scripts.
The .gradle folder is copied to build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0, I am not sure this is desired.
Some library versions are different in case of ant and gradle build.
I am posting the relevant lines from the diff output:
Only in buildgradle/bin: sqoop-codegen.bat
Only in buildgradle/bin: sqoop-create-hive-table.bat
Only in buildgradle/bin: sqoop-eval.bat
Only in buildgradle/bin: sqoop-export.bat
Only in buildgradle/bin: sqoop-help.bat
Only in buildgradle/bin: sqoop-import-all-tables.bat
Only in buildgradle/bin: sqoop-import-mainframe.bat
Only in buildgradle/bin: sqoop-import.bat
Only in buildgradle/bin: sqoop-job.bat
Only in buildgradle/bin: sqoop-list-databases.bat
Only in buildgradle/bin: sqoop-list-tables.bat
Only in buildgradle/bin: sqoop-merge.bat
Only in buildgradle/bin: sqoop-metastore.bat
Only in buildgradle/bin: sqoop-version.bat
Only in build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1: file-changes
Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/fileContent/fileContent.lock and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/fileContent/fileContent.lock differ
Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileHashes.bin and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileHashes.bin differ
Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileSnapshots.bin and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/fileSnapshots.bin differ
Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.bin and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.bin differ
Binary files build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.lock and buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/.gradle/3.5.1/taskHistory/taskHistory.lock differ
Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: avro-ipc-1.8.1.jar
Only in build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: commons-codec-1.4.jar
Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: commons-codec-1.9.jar
Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: parquet-hive-bundle-1.6.0.jar
Only in build/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: slf4j-api-1.6.1.jar
Only in buildgradle/sqoop-1.5.0-SNAPSHOT.bin__hadoop-2.6.0/lib: slf4j-api-1.7.7.jar
COMPILING.txt
Lines 206 (patched)
<https://reviews.apache.org/r/66067/#comment280038>
typo: gradlew
COMPILING.txt
Lines 215 (patched)
<https://reviews.apache.org/r/66067/#comment280039>
typo: gradlew
config/checkstyle/checkstyle-noframes.xsl
Lines 200 (patched)
<https://reviews.apache.org/r/66067/#comment280040>
There are 2 new lines at the end of this line, git gives a warning when the patch is applied.
- Szabolcs Vasas
On March 19, 2018, 1:55 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 1:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28
> COMPILING.txt 86be509
> build.gradle PRE-CREATION
> buildSrc/customUnixStartScript.txt PRE-CREATION
> buildSrc/customWindowsStartScript.txt PRE-CREATION
> buildSrc/sqoop-package.gradle PRE-CREATION
> buildSrc/sqoop-version-gen.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66067/diff/1/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>