You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2016/03/30 00:07:18 UTC
[GitHub] qpid-dispatch pull request: DISPATCH-200 - Add a flexible mapping ...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/61
DISPATCH-200 - Add a flexible mapping from x.509 certificate fields t…
…o an identity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-200-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit 56e56ce2ee00fcca49d574c276f8e7dba2ca6187
Author: Ganesh Murthy <gm...@redhat.com>
Date: 2016-03-29T22:03:29Z
DISPATCH-200 - Add a flexible mapping from x.509 certificate fields to an identity
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-200 - Add a flexible mapping ...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/61#discussion_r57875819
--- Diff: src/container.c ---
@@ -21,6 +21,7 @@
#include <string.h>
#include "dispatch_private.h"
#include "connection_manager_private.h"
+#include "server_private.h"
--- End diff --
It would be better to not add this private linkage between container and server. Rather, put the signature for qd_connection_set_user into the public server.h file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-200 - Add a flexible mapping ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-200 - Add a flexible mapping ...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/61#discussion_r57876034
--- Diff: tests/management/qdrouter.py ---
@@ -82,22 +81,11 @@ def do_test_qdrouter_parse(self, text):
conf = Config()
content = conf._parse(text.split("\n"))
self.maxDiff = None
- expect = [
- [u"router", {u"mode":u"standalone"}],
- [u"sslProfile", {u"name":u"test-profile", u"password":u"secret"}],
- [u"listener", {u"name":u"l0", u"saslMechanisms":u"ANONYMOUS", u"sslProfile":u"test-profile"}],
- [u"listener", {u"identity":u"l1", u"saslMechanisms":u"ANONYMOUS", u"port":u"1234"}],
- [u"listener", {u"saslMechanisms":u"ANONYMOUS", u"port":u"4567"}]
- ]
+ expect = [[u'router', {u'mode': u'standalone'}], [u'sslProfile', {u'password': u'secret', u'name': u'test-profile'}], [u'listener', {u'sslProfile': u'test-profile', u'name': u'l0', u'saslMechanisms': u'ANONYMOUS'}], [u'listener', {u'saslMechanisms': u'ANONYMOUS', u'identity': u'l1', u'port': u'1234'}], [u'listener', {u'saslMechanisms': u'ANONYMOUS', u'port': u'4567'}]]
--- End diff --
Why did you change these? They were so much more readable before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org