You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2014/07/25 10:36:10 UTC
[GitHub] incubator-flink pull request: [FLINK-1032] Allow Access of Nested ...
GitHub user aljoscha opened a pull request:
https://github.com/apache/incubator-flink/pull/79
[FLINK-1032] Allow Access of Nested Fields in POJO Field Expressions
This extends the PojoTypeInfo to allow key expressions like "foo.bar".
Right now the implementation is not very pretty but without turning to
code generation this is the way to do it, IMHO.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/incubator-flink pojo-nested-field-selectors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 05d17ac2a11b25ee2294b92342dfeeb7dd939c24
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2014-07-23T14:41:08Z
[FLINK-1032] Allow Access of Nested Fields in POJO Field Expressions
This extends the PojoTypeInfo to allow key expressions like "foo.bar".
Right now the implementation is not very pretty but without turning to
code generation this is the way to do it, IMHO.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1032] Allow Access of Nested ...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/incubator-flink/pull/79#issuecomment-54287301
Closing it since @rmetzger took over.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1032] Allow Access of Nested ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/79#discussion_r15434384
--- Diff: flink-core/src/main/java/org/apache/flink/types/TypeInformation.java ---
@@ -21,6 +21,10 @@
import org.apache.flink.api.common.typeutils.TypeSerializer;
public abstract class TypeInformation<T> {
+ protected final String NO_POJO_WARNING = "Field expressions can only be used on POJOs." + " " +
+ "A POCO must have a default constructor without arguments and not have readObject" +
--- End diff --
I think POCO is a typo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1032] Allow Access of Nested ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/79#issuecomment-54080134
I've picked up the work here to continue working on https://issues.apache.org/jira/browse/FLINK-1032.
You can find the current work in progress here: https://github.com/rmetzger/incubator-flink/tree/pojo-nested-field-selectors
I would suggest to close this pull request. The three commits from this PR will be contained in the PR that I'm going to open.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1032] Allow Access of Nested ...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/incubator-flink/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1032] Allow Access of Nested ...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/incubator-flink/pull/79#issuecomment-50257908
Fixed the typo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---