You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/08/25 09:39:09 UTC
[GitHub] [fineract] logoutdhaval opened a new pull request, #2540: Error with withdraw/deposit transactions after initiating hold transa…
logoutdhaval opened a new pull request, #2540:
URL: https://github.com/apache/fineract/pull/2540
## Description
Describe the changes made and why they were made.
[FINERACT-1705](https://issues.apache.org/jira/browse/FINERACT-1705).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #2540: FINERACT-1705 : Error with withdraw/deposit transactions after initiating hold transa…
Posted by GitBox <gi...@apache.org>.
awasum commented on PR #2540:
URL: https://github.com/apache/fineract/pull/2540#issuecomment-1228191878
Understood. Thanks for receiving it well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #2540: FINERACT-1705 : Error with withdraw/deposit transactions after initiating hold transa…
Posted by GitBox <gi...@apache.org>.
awasum commented on PR #2540:
URL: https://github.com/apache/fineract/pull/2540#issuecomment-1227870295
See: https://github.com/apache/fineract/#pull-requests which you ticked above but did not comply with the rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #2540: FINERACT-1705 : Error with withdraw/deposit transactions after initiating hold transa…
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on PR #2540:
URL: https://github.com/apache/fineract/pull/2540#issuecomment-1227968199
@awasum, it was an oversight from our side, I shall double check on this inin future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj merged pull request #2540: Error with withdraw/deposit transactions after initiating hold transa…
Posted by GitBox <gi...@apache.org>.
fynmanoj merged PR #2540:
URL: https://github.com/apache/fineract/pull/2540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #2540: FINERACT-1705 : Error with withdraw/deposit transactions after initiating hold transa…
Posted by GitBox <gi...@apache.org>.
awasum commented on PR #2540:
URL: https://github.com/apache/fineract/pull/2540#issuecomment-1227869772
@logoutdhaval Please next time, the commit should include the Fineract JIRA ticket (FINERACT-1705) so that it will show up on JIRA.
@fynmanoj Let's try to make sure PRs we merge follow conventions so that release notes will include these commits and provide transparency and ease maintenance and regression test/debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org