You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/03/14 13:48:19 UTC

[PR] [fix](clucene) Fix GCC -Werror compilation errors in TermDocsBuffer and SegmentTermVector [doris-thirdparty]

airborne12 opened a new pull request, #384:
URL: https://github.com/apache/doris-thirdparty/pull/384

   ## Summary
   
   Fix two GCC `-Werror` compilation errors that cause the Doris Performance pipeline to fail (build uses GCC + RELEASE mode with stricter warnings than Clang).
   
   - **`_SegmentHeader.h`**: Reorder `TermDocsBuffer` constructor initializer list to match member declaration order, fixing `-Werror=reorder`. The pairs `maxDoc`/`freqStream_` and `indexVersion_`/`compatibleRead_` were swapped relative to their declarations.
   - **`_TermVector.h`**: Enable virtual inheritance for `SegmentTermVector` from `TermFreqVector` (uncomment the already-planned `/*virtual*/`), fixing `-Werror=inaccessible-base` diamond inheritance when `SegmentTermPositionVector` inherits from both `SegmentTermVector` and `TermPositionVector`.
   
   ## Related
   
   - Doris PR: https://github.com/apache/doris/pull/59847
   - TeamCity Performance build failure: http://43.132.222.7:8111/viewLog.html?buildId=906605
   
   ## Test plan
   
   - [ ] Verify GCC compilation passes without `-Werror=reorder` and `-Werror=inaccessible-base`
   - [ ] Verify Clang compilation still passes (no regression)
   - [ ] Re-run Doris Performance pipeline after updating submodule reference


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](clucene) Fix GCC -Werror compilation errors in TermDocsBuffer and SegmentTermVector [doris-thirdparty]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #384:
URL: https://github.com/apache/doris-thirdparty/pull/384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org