You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/15 21:30:34 UTC

[GitHub] [arrow] westonpace commented on pull request #11165: ARROW-14009: [C++] Seed parallellism in SourceNode

westonpace commented on pull request #11165:
URL: https://github.com/apache/arrow/pull/11165#issuecomment-920396759


   @lidavidm `VisitAsyncGenerator`'s visitor should return `Status` so you can still communicate errors (which cause the visiting to stop).  I see that it might not be able to interact with `stop_requested_` though (but that could be done in a general way by adding an optional `StopToken` to `VisitAsyncGenerator`).  So I suppose I won't push for that change.  This looks pretty good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org