You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Carlos Rovira <ca...@apache.org> on 2020/10/27 11:30:23 UTC
latest changes in compiler seems to have repercusions in TDJ
Hi Josh,
just let you know that after rebuild today I'm having issues in TDJ
building that shows mainly 2 things:
- Tabs appear without labels
- The main drawer navigation is not launching the corresponding content
as expected
Could this be related to latest changes done in compiler? Can you take a
look please?
Thanks in advance for your help.
--
Carlos Rovira
Apache Member & Apache Royale PMC
*Apache Software Foundation*
http://about.me/carlosrovira
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Carlos Rovira <ca...@apache.org>.
Hi,
Finally the problem in Tabbar was not on the compiler, but on changes I did
in renderers, so sorry for the noise about this.
I didn't see it when I did it, which is strange.
The other one (drawer navigation), was a problem in SectionContent leaving
"is-selected" class selector. That wasn't happening before. So that seems
to me caused by recent changes, but since it was kind of a hack for some
problem in SectionContent sizing and positioning when starts hidden, I can
assure it is not ok. So really this one was caused by changes in compiler,
but I fixed (hopefully) in jewel code.
HTH
El mié., 28 oct. 2020 a las 9:05, Greg Dove (<gr...@gmail.com>)
escribió:
> Hi Chris, these are the framework tests we have discussed in the past. They
> are not run in maven, only in ant build at this point.
>
> They have caught compiler changes in the past, but obviously not this
> issue, whatever it is, so that would mean there needs to be a new test to
> cover it, once we figure out what it is.
>
> Greg
>
>
> On Wed, Oct 28, 2020 at 9:00 PM Christofer Dutz <christofer.dutz@c-ware.de
> >
> wrote:
>
> > Hi Josh,
> >
> > could you please point me to this testsuite? Were there just no tests to
> > detect this current issue and they are now added to keep this base
> covered
> > in the future?
> >
> > Chris
> >
> > Am 27.10.20, 18:48 schrieb "Josh Tynjala" <jo...@bowlerhat.dev>:
> >
> > We have many automated tests for both the compiler and framework, and
> > they
> > continue to grow over time. The compiler has a pretty extensive suite
> > of
> > JUnit tests, and I also ported FlexUnit (now called RoyaleUnit) for
> > automated testing of the framework libraries.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Tue, Oct 27, 2020 at 10:40 AM Christofer Dutz <
> > christofer.dutz@c-ware.de>
> > wrote:
> >
> > > Hi all,
> > >
> > > I think we should probably invest some time in creating automated
> > tests to
> > > find this sort of thing ...
> > > I know such a test-suite will in the beginning not find every
> issue,
> > but
> > > we could add tests whenever we run into a problem like this and
> over
> > time
> > > it would become a more and more solid test-harness.
> > >
> > > What do you think?
> > >
> > > I'd be happy to help.
> > >
> > > Chris
> > >
> > >
> > >
> > > Am 27.10.20, 18:22 schrieb "Piotr Zarzycki" <
> > piotrzarzycki21@gmail.com>:
> > >
> > > Sorry in our case I don't see content for some reason, but
> > labels are
> > > ok.
> > >
> > > wt., 27 paź 2020 o 18:22 Piotr Zarzycki <
> > piotrzarzycki21@gmail.com>
> > > napisał(a):
> > >
> > > > Ufortunately I'm experiencing same issue in our MyAccount
> > > application with
> > > > TabBar :(
> > > >
> > > > wt., 27 paź 2020 o 12:30 Carlos Rovira <
> > carlosrovira@apache.org>
> > > > napisał(a):
> > > >
> > > >> Hi Josh,
> > > >>
> > > >> just let you know that after rebuild today I'm having issues
> > in TDJ
> > > >> building that shows mainly 2 things:
> > > >>
> > > >>
> > > >> - Tabs appear without labels
> > > >> - The main drawer navigation is not launching the
> > corresponding
> > > content
> > > >> as expected
> > > >>
> > > >> Could this be related to latest changes done in compiler?
> Can
> > you
> > > take a
> > > >> look please?
> > > >>
> > > >> Thanks in advance for your help.
> > > >>
> > > >> --
> > > >> Carlos Rovira
> > > >> Apache Member & Apache Royale PMC
> > > >> *Apache Software Foundation*
> > > >> http://about.me/carlosrovira
> > > >>
> > > >
> > > >
> > > > --
> > > >
> > > > Piotr Zarzycki
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > >
> >
> >
>
--
Carlos Rovira
Apache Member & Apache Royale PMC
*Apache Software Foundation*
http://about.me/carlosrovira
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Greg
Well I guess then I should probably help get the tests running in Maven ... correct?
Anyone willing to help me with it? Ideally someone with knowledge of the Ant version.
Chris
Am 28.10.20, 09:05 schrieb "Greg Dove" <gr...@gmail.com>:
Hi Chris, these are the framework tests we have discussed in the past. They
are not run in maven, only in ant build at this point.
They have caught compiler changes in the past, but obviously not this
issue, whatever it is, so that would mean there needs to be a new test to
cover it, once we figure out what it is.
Greg
On Wed, Oct 28, 2020 at 9:00 PM Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi Josh,
>
> could you please point me to this testsuite? Were there just no tests to
> detect this current issue and they are now added to keep this base covered
> in the future?
>
> Chris
>
> Am 27.10.20, 18:48 schrieb "Josh Tynjala" <jo...@bowlerhat.dev>:
>
> We have many automated tests for both the compiler and framework, and
> they
> continue to grow over time. The compiler has a pretty extensive suite
> of
> JUnit tests, and I also ported FlexUnit (now called RoyaleUnit) for
> automated testing of the framework libraries.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Oct 27, 2020 at 10:40 AM Christofer Dutz <
> christofer.dutz@c-ware.de>
> wrote:
>
> > Hi all,
> >
> > I think we should probably invest some time in creating automated
> tests to
> > find this sort of thing ...
> > I know such a test-suite will in the beginning not find every issue,
> but
> > we could add tests whenever we run into a problem like this and over
> time
> > it would become a more and more solid test-harness.
> >
> > What do you think?
> >
> > I'd be happy to help.
> >
> > Chris
> >
> >
> >
> > Am 27.10.20, 18:22 schrieb "Piotr Zarzycki" <
> piotrzarzycki21@gmail.com>:
> >
> > Sorry in our case I don't see content for some reason, but
> labels are
> > ok.
> >
> > wt., 27 paź 2020 o 18:22 Piotr Zarzycki <
> piotrzarzycki21@gmail.com>
> > napisał(a):
> >
> > > Ufortunately I'm experiencing same issue in our MyAccount
> > application with
> > > TabBar :(
> > >
> > > wt., 27 paź 2020 o 12:30 Carlos Rovira <
> carlosrovira@apache.org>
> > > napisał(a):
> > >
> > >> Hi Josh,
> > >>
> > >> just let you know that after rebuild today I'm having issues
> in TDJ
> > >> building that shows mainly 2 things:
> > >>
> > >>
> > >> - Tabs appear without labels
> > >> - The main drawer navigation is not launching the
> corresponding
> > content
> > >> as expected
> > >>
> > >> Could this be related to latest changes done in compiler? Can
> you
> > take a
> > >> look please?
> > >>
> > >> Thanks in advance for your help.
> > >>
> > >> --
> > >> Carlos Rovira
> > >> Apache Member & Apache Royale PMC
> > >> *Apache Software Foundation*
> > >> http://about.me/carlosrovira
> > >>
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> >
>
>
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Greg Dove <gr...@gmail.com>.
Hi Chris, these are the framework tests we have discussed in the past. They
are not run in maven, only in ant build at this point.
They have caught compiler changes in the past, but obviously not this
issue, whatever it is, so that would mean there needs to be a new test to
cover it, once we figure out what it is.
Greg
On Wed, Oct 28, 2020 at 9:00 PM Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi Josh,
>
> could you please point me to this testsuite? Were there just no tests to
> detect this current issue and they are now added to keep this base covered
> in the future?
>
> Chris
>
> Am 27.10.20, 18:48 schrieb "Josh Tynjala" <jo...@bowlerhat.dev>:
>
> We have many automated tests for both the compiler and framework, and
> they
> continue to grow over time. The compiler has a pretty extensive suite
> of
> JUnit tests, and I also ported FlexUnit (now called RoyaleUnit) for
> automated testing of the framework libraries.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Oct 27, 2020 at 10:40 AM Christofer Dutz <
> christofer.dutz@c-ware.de>
> wrote:
>
> > Hi all,
> >
> > I think we should probably invest some time in creating automated
> tests to
> > find this sort of thing ...
> > I know such a test-suite will in the beginning not find every issue,
> but
> > we could add tests whenever we run into a problem like this and over
> time
> > it would become a more and more solid test-harness.
> >
> > What do you think?
> >
> > I'd be happy to help.
> >
> > Chris
> >
> >
> >
> > Am 27.10.20, 18:22 schrieb "Piotr Zarzycki" <
> piotrzarzycki21@gmail.com>:
> >
> > Sorry in our case I don't see content for some reason, but
> labels are
> > ok.
> >
> > wt., 27 paź 2020 o 18:22 Piotr Zarzycki <
> piotrzarzycki21@gmail.com>
> > napisał(a):
> >
> > > Ufortunately I'm experiencing same issue in our MyAccount
> > application with
> > > TabBar :(
> > >
> > > wt., 27 paź 2020 o 12:30 Carlos Rovira <
> carlosrovira@apache.org>
> > > napisał(a):
> > >
> > >> Hi Josh,
> > >>
> > >> just let you know that after rebuild today I'm having issues
> in TDJ
> > >> building that shows mainly 2 things:
> > >>
> > >>
> > >> - Tabs appear without labels
> > >> - The main drawer navigation is not launching the
> corresponding
> > content
> > >> as expected
> > >>
> > >> Could this be related to latest changes done in compiler? Can
> you
> > take a
> > >> look please?
> > >>
> > >> Thanks in advance for your help.
> > >>
> > >> --
> > >> Carlos Rovira
> > >> Apache Member & Apache Royale PMC
> > >> *Apache Software Foundation*
> > >> http://about.me/carlosrovira
> > >>
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> >
>
>
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Josh,
could you please point me to this testsuite? Were there just no tests to detect this current issue and they are now added to keep this base covered in the future?
Chris
Am 27.10.20, 18:48 schrieb "Josh Tynjala" <jo...@bowlerhat.dev>:
We have many automated tests for both the compiler and framework, and they
continue to grow over time. The compiler has a pretty extensive suite of
JUnit tests, and I also ported FlexUnit (now called RoyaleUnit) for
automated testing of the framework libraries.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Oct 27, 2020 at 10:40 AM Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi all,
>
> I think we should probably invest some time in creating automated tests to
> find this sort of thing ...
> I know such a test-suite will in the beginning not find every issue, but
> we could add tests whenever we run into a problem like this and over time
> it would become a more and more solid test-harness.
>
> What do you think?
>
> I'd be happy to help.
>
> Chris
>
>
>
> Am 27.10.20, 18:22 schrieb "Piotr Zarzycki" <pi...@gmail.com>:
>
> Sorry in our case I don't see content for some reason, but labels are
> ok.
>
> wt., 27 paź 2020 o 18:22 Piotr Zarzycki <pi...@gmail.com>
> napisał(a):
>
> > Ufortunately I'm experiencing same issue in our MyAccount
> application with
> > TabBar :(
> >
> > wt., 27 paź 2020 o 12:30 Carlos Rovira <ca...@apache.org>
> > napisał(a):
> >
> >> Hi Josh,
> >>
> >> just let you know that after rebuild today I'm having issues in TDJ
> >> building that shows mainly 2 things:
> >>
> >>
> >> - Tabs appear without labels
> >> - The main drawer navigation is not launching the corresponding
> content
> >> as expected
> >>
> >> Could this be related to latest changes done in compiler? Can you
> take a
> >> look please?
> >>
> >> Thanks in advance for your help.
> >>
> >> --
> >> Carlos Rovira
> >> Apache Member & Apache Royale PMC
> >> *Apache Software Foundation*
> >> http://about.me/carlosrovira
> >>
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
>
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
We have many automated tests for both the compiler and framework, and they
continue to grow over time. The compiler has a pretty extensive suite of
JUnit tests, and I also ported FlexUnit (now called RoyaleUnit) for
automated testing of the framework libraries.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Oct 27, 2020 at 10:40 AM Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi all,
>
> I think we should probably invest some time in creating automated tests to
> find this sort of thing ...
> I know such a test-suite will in the beginning not find every issue, but
> we could add tests whenever we run into a problem like this and over time
> it would become a more and more solid test-harness.
>
> What do you think?
>
> I'd be happy to help.
>
> Chris
>
>
>
> Am 27.10.20, 18:22 schrieb "Piotr Zarzycki" <pi...@gmail.com>:
>
> Sorry in our case I don't see content for some reason, but labels are
> ok.
>
> wt., 27 paź 2020 o 18:22 Piotr Zarzycki <pi...@gmail.com>
> napisał(a):
>
> > Ufortunately I'm experiencing same issue in our MyAccount
> application with
> > TabBar :(
> >
> > wt., 27 paź 2020 o 12:30 Carlos Rovira <ca...@apache.org>
> > napisał(a):
> >
> >> Hi Josh,
> >>
> >> just let you know that after rebuild today I'm having issues in TDJ
> >> building that shows mainly 2 things:
> >>
> >>
> >> - Tabs appear without labels
> >> - The main drawer navigation is not launching the corresponding
> content
> >> as expected
> >>
> >> Could this be related to latest changes done in compiler? Can you
> take a
> >> look please?
> >>
> >> Thanks in advance for your help.
> >>
> >> --
> >> Carlos Rovira
> >> Apache Member & Apache Royale PMC
> >> *Apache Software Foundation*
> >> http://about.me/carlosrovira
> >>
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
>
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,
I think we should probably invest some time in creating automated tests to find this sort of thing ...
I know such a test-suite will in the beginning not find every issue, but we could add tests whenever we run into a problem like this and over time it would become a more and more solid test-harness.
What do you think?
I'd be happy to help.
Chris
Am 27.10.20, 18:22 schrieb "Piotr Zarzycki" <pi...@gmail.com>:
Sorry in our case I don't see content for some reason, but labels are ok.
wt., 27 paź 2020 o 18:22 Piotr Zarzycki <pi...@gmail.com>
napisał(a):
> Ufortunately I'm experiencing same issue in our MyAccount application with
> TabBar :(
>
> wt., 27 paź 2020 o 12:30 Carlos Rovira <ca...@apache.org>
> napisał(a):
>
>> Hi Josh,
>>
>> just let you know that after rebuild today I'm having issues in TDJ
>> building that shows mainly 2 things:
>>
>>
>> - Tabs appear without labels
>> - The main drawer navigation is not launching the corresponding content
>> as expected
>>
>> Could this be related to latest changes done in compiler? Can you take a
>> look please?
>>
>> Thanks in advance for your help.
>>
>> --
>> Carlos Rovira
>> Apache Member & Apache Royale PMC
>> *Apache Software Foundation*
>> http://about.me/carlosrovira
>>
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Piotr Zarzycki <pi...@gmail.com>.
Sorry in our case I don't see content for some reason, but labels are ok.
wt., 27 paź 2020 o 18:22 Piotr Zarzycki <pi...@gmail.com>
napisał(a):
> Ufortunately I'm experiencing same issue in our MyAccount application with
> TabBar :(
>
> wt., 27 paź 2020 o 12:30 Carlos Rovira <ca...@apache.org>
> napisał(a):
>
>> Hi Josh,
>>
>> just let you know that after rebuild today I'm having issues in TDJ
>> building that shows mainly 2 things:
>>
>>
>> - Tabs appear without labels
>> - The main drawer navigation is not launching the corresponding content
>> as expected
>>
>> Could this be related to latest changes done in compiler? Can you take a
>> look please?
>>
>> Thanks in advance for your help.
>>
>> --
>> Carlos Rovira
>> Apache Member & Apache Royale PMC
>> *Apache Software Foundation*
>> http://about.me/carlosrovira
>>
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: latest changes in compiler seems to have repercusions in TDJ
Posted by Piotr Zarzycki <pi...@gmail.com>.
Ufortunately I'm experiencing same issue in our MyAccount application with
TabBar :(
wt., 27 paź 2020 o 12:30 Carlos Rovira <ca...@apache.org> napisał(a):
> Hi Josh,
>
> just let you know that after rebuild today I'm having issues in TDJ
> building that shows mainly 2 things:
>
>
> - Tabs appear without labels
> - The main drawer navigation is not launching the corresponding content
> as expected
>
> Could this be related to latest changes done in compiler? Can you take a
> look please?
>
> Thanks in advance for your help.
>
> --
> Carlos Rovira
> Apache Member & Apache Royale PMC
> *Apache Software Foundation*
> http://about.me/carlosrovira
>
--
Piotr Zarzycki