You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "tabish121 (via GitHub)" <gi...@apache.org> on 2024/01/19 20:40:23 UTC
[PR] ARTEMIS-4575 Only start the consumers that were added [activemq-artemis]
tabish121 opened a new pull request, #4754:
URL: https://github.com/apache/activemq-artemis/pull/4754
Change from forcing a session start cycle on each consumer add event and start only those consumers that were added which will trigger a prompt delivery action on each. The session should be marked started on create to account for the remove of the start on each consumer add event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4575 Only start the consumers that were added [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #4754:
URL: https://github.com/apache/activemq-artemis/pull/4754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4575 Only start the consumers that were added [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4754:
URL: https://github.com/apache/activemq-artemis/pull/4754#issuecomment-1904594225
I'm actually planning to cut a release this week. I will send a heads up to the dev-list...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4575 Only start the consumers that were added [activemq-artemis]
Posted by "joshb1050 (via GitHub)" <gi...@apache.org>.
joshb1050 commented on PR #4754:
URL: https://github.com/apache/activemq-artemis/pull/4754#issuecomment-1901099809
Agreed this makes more sense than #4754, especially isolating impact to OpenWire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4575 Only start the consumers that were added [activemq-artemis]
Posted by "joshb1050 (via GitHub)" <gi...@apache.org>.
joshb1050 commented on PR #4754:
URL: https://github.com/apache/activemq-artemis/pull/4754#issuecomment-1904327366
@tabish121 Thanks for the quick PR and merge on this—is there an estimate for when a new release will be cut with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4575 Only start the consumers that were added [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on PR #4754:
URL: https://github.com/apache/activemq-artemis/pull/4754#issuecomment-1901084917
I've run the full test suite on this and all the tests passed. I don't see any simple unit test for this as the desired outcome is that there should be no change other than a reduction in resource utilization on consumer adds to an existing session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org