You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/30 02:26:25 UTC
[GitHub] [dolphinscheduler] devosend opened a new issue #7717: [Bug] [UI Next] ESLint errors
devosend opened a new issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
I get some problems and errors when I run `npm run lint` in dolphinscheduler-ui-next. as follows:
It seems to be because of the eslint rules is not effect.
### What you expected to happen
`npm run lint` not errors.
### How to reproduce
`npm run lint` in dolphinscheduler-ui-next.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend edited a comment on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend edited a comment on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002848613
> > Please confirm this question if you have time. @songjianet
>
> The format code can use the command `prettier`.
yes, `prettier` is used to format the code. but the config of `.prettier.js` and `.eslintrc.js` conflict beause of `quotes` and `comma-dangle` rule is not effect in `.eslintrc.js`. by the way don't you report errors when you execute `npm run lint` locally? @songjianet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie closed issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002846985
> > Please confirm this question if you have time. @songjianet
>
> The format code can use the command `prettier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002845883
Please confirm this question if you have time. @songjianet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend edited a comment on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend edited a comment on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1003737681
> > > > Please confirm this question if you have time. @songjianet
> > >
> > >
> > > The format code can use the command `prettier`.
> >
> >
> > yes, `prettier` is used to format the code. but the config of `.prettier.js` and `.eslintrc.js` conflict beause of `quotes` and `comma-dangle` rule is not effect in `.eslintrc.js`. by the way don't you report errors when you execute `npm run lint` locally? @songjianet
>
> Yes, currently we have three people developing the new `ui`, and they can run normally using `webstorm` and `vscode` respectively.
Thans for your answer，but I find `eslint-config-prettier` can't found `pretter`'s config, bease of `.pretter.js` is not support for `pretter`. the official profile names supported are as follows:
.
You can run `npm run prettier` correctly because the configuration file name is specified by the `--config` parameter.
but `eslint` can't recognize it.
In addition the code has other obvious styles for `eslint`. examples:
this file is `veiws/home/index.tsx`.
Based on these I don't think you can run `npm run lint` without reporting errors.
Hope your reply @songjianet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1003737681
> > > > Please confirm this question if you have time. @songjianet
> > >
> > >
> > > The format code can use the command `prettier`.
> >
> >
> > yes, `prettier` is used to format the code. but the config of `.prettier.js` and `.eslintrc.js` conflict beause of `quotes` and `comma-dangle` rule is not effect in `.eslintrc.js`. by the way don't you report errors when you execute `npm run lint` locally? @songjianet
>
> Yes, currently we have three people developing the new `ui`, and they can run normally using `webstorm` and `vscode` respectively.
Thans for your answer，but I find `eslint-config-prettier` can't found `pretter`'s config, bease of `.pretter.js` is not support for `pretter`. the official profile names supported are as follows:
.
You can run `npm run prettier` correctly because the configuration file name is specified by the `--config` parameter.
but `eslint` can't recognize it.
In addition the code has other obvious styles for `eslint`. examples:
this file is `veiws/home/index.tsx`.
Based on these I don't think you can run `npm run lint` without reporting errors.
Looking forward to your reply @songjianet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002847060
> > Please confirm this question if you have time. @songjianet
>
> The format code can use the command `prettier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
songjianet commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002846257
> Please confirm this question if you have time. @songjianet
The format code can use the command `prettier`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend removed a comment on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend removed a comment on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002846985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend closed issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend closed issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002845763
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
devosend commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002848613
> > Please confirm this question if you have time. @songjianet
>
> The format code can use the command `prettier`.
yes, `prettier` is used to format the code. but the config of `.prettier.js` and `.eslintrc.js` conflict beause of `quotes` and `comma-dangle` rule is not effect in `.eslintrc.js`. by the way don't you report errors when you execute `npm run lint` locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on issue #7717: [Bug] [UI Next] ESLint errors
Posted by GitBox <gi...@apache.org>.
songjianet commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1002922026
> > > Please confirm this question if you have time. @songjianet
> >
> >
> > The format code can use the command `prettier`.
>
> yes, `prettier` is used to format the code. but the config of `.prettier.js` and `.eslintrc.js` conflict beause of `quotes` and `comma-dangle` rule is not effect in `.eslintrc.js`. by the way don't you report errors when you execute `npm run lint` locally? @songjianet
Yes, currently we have three people developing the new `ui`, and they can run normally using `webstorm` and `vscode` respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org