You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by MrRaindrop <gi...@git.apache.org> on 2017/06/20 08:51:33 UTC
[GitHub] incubator-weex pull request #455: [vue-render] fix refresh & loading & loadi...
GitHub user MrRaindrop opened a pull request:
https://github.com/apache/incubator-weex/pull/455
[vue-render] fix refresh & loading & loading-indicator.
bugfixes:
* fix height of `refresh` / `loading`.
* fix size of `loading-indicator`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MrRaindrop/incubator-weex 0.14-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #455
----
commit 19df3a1374a05e66e90aae3794264e75ba220747
Author: MrRaindrop <te...@gmail.com>
Date: 2017-06-20T03:48:41Z
* [html5] fix refresh & loading & loading-indicator.
* [html5] update
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #455: [vue-render] fix refresh & loading & loadi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #455: [vue-render] fix refresh & loading & loading-indi...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/455
<!--
1 failure: This PR modify SD...
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @Hanks10100 , @fkysly to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---