You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/07/26 21:22:04 UTC
[GitHub] [pinot] xiangfu0 opened a new issue, #11187: [multistage]Leaf stage unavailable segment may fail query execution
xiangfu0 opened a new issue, #11187:
URL: https://github.com/apache/pinot/issues/11187
Assume there is a table A on serve-0 with only 1 segment, 1 replica.
During mailbox assignment, the routing table gives routing as no serverInstance mapping, and one unavailable segment.
It turns out to make physical plan intermediate stage mailboxRecv has no linking mailboxSend, then the plan compilation failed.
Ideally, we should give an empty DataTable with a partial result exception listing the unavailable segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #11187: [multistage]Leaf stage unavailable segment or empty table may fail query execution
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #11187: [multistage]Leaf stage unavailable segment or empty table may fail query execution
URL: https://github.com/apache/pinot/issues/11187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ege-st commented on issue #11187: [multistage]Leaf stage unavailable segment or empty table may fail query execution
Posted by "ege-st (via GitHub)" <gi...@apache.org>.
ege-st commented on issue #11187:
URL: https://github.com/apache/pinot/issues/11187#issuecomment-1694763177
@xiangfu0 @walterddr looks like we can close this bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #11187: [multistage]Leaf stage unavailable segment or empty table may fail query execution
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on issue #11187:
URL: https://github.com/apache/pinot/issues/11187#issuecomment-1654709741
> looks like the issue is here:
>
> https://github.com/apache/pinot/blob/2904f1bce19f93b4e6f2f6492e741a5adc02dd82/pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java#L124-L132
>
> ^ it shouldn't attach the server instance if list of segments are empty
This issue is triggered when all the segments on that server become unavailable, then you still have the ServerInstance mapping, but no available segment, then leaf stage is not assigned still.
IMO, there are two ways to fix: 1. assign a leaf stage with empty segment list; 2. don't schedule leaf, just let intermediate stage mailboxRecv return empty data block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #11187: [multistage]Leaf stage unavailable segment or empty table may fail query execution
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on issue #11187:
URL: https://github.com/apache/pinot/issues/11187#issuecomment-1655252683
A try to fix this: https://github.com/apache/pinot/pull/11201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #11187: [multistage]Leaf stage unavailable segment or empty table may fail query execution
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #11187:
URL: https://github.com/apache/pinot/issues/11187#issuecomment-1654689842
looks like the issue is here:
https://github.com/apache/pinot/blob/2904f1bce19f93b4e6f2f6492e741a5adc02dd82/pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java#L124-L132
^ it shouldn't attach the server instance if list of segments are empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org