You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/15 17:51:34 UTC

[GitHub] [arrow-rs] 51yu opened a new issue, #1570: RecordWriter trait definition

51yu opened a new issue, #1570:
URL: https://github.com/apache/arrow-rs/issues/1570

   **Which part is this question about**
   parquet library api
   
   **Describe your question**
   Do we need generic for [`RecordWriter`](https://github.com/apache/arrow-rs/blob/master/parquet/src/record/record_writer.rs#L23) ?
   Looking into trait signatures `schema` and `write_to_group`, I didn't see `T` is used.
   Also, in [derive](https://github.com/apache/arrow-rs/blob/master/parquet_derive/src/lib.rs#L100)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #1570: Parquet RecordWriter Trait Definition

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1570:
URL: https://github.com/apache/arrow-rs/issues/1570#issuecomment-1100872247

   It appears to be used as part of parquet-derive test: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/parquet/src/record/record_writer.rs?L23:11&subtree=true#tab=references
   
   Maybe it could be removed / moved to just that crate?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org