You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/30 06:26:52 UTC

[GitHub] jai1 commented on a change in pull request #1123: Configure a max producer/consumer queue size enforced across partitions

jai1 commented on a change in pull request #1123: Configure a max producer/consumer queue size enforced across partitions
URL: https://github.com/apache/incubator-pulsar/pull/1123#discussion_r164650547
 
 

 ##########
 File path: pulsar-client-cpp/lib/ProducerConfiguration.cc
 ##########
 @@ -73,6 +73,18 @@ ProducerConfiguration& ProducerConfiguration::setMaxPendingMessages(int maxPendi
 
 int ProducerConfiguration::getMaxPendingMessages() const { return impl_->maxPendingMessages; }
 
+ProducerConfiguration& ProducerConfiguration::setMaxPendingMessagesAcrossPartitions(int maxPendingMessages) {
+    if (maxPendingMessages <= 0) {
 
 Review comment:
   Assert instead of throw

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services