You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/05/27 00:55:52 UTC

Review Request 59615: HIVE-16778 LLAP IO: better refcount management

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59615/
-----------------------------------------------------------

Review request for hive and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 969382681f 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReader.java ea9904ad7e 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 6cd85d29fd 


Diff: https://reviews.apache.org/r/59615/diff/1/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 59615: HIVE-16778 LLAP IO: better refcount management

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59615/
-----------------------------------------------------------

(Updated May 27, 2017, 1:02 a.m.)


Review request for hive and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 969382681f 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReader.java ea9904ad7e 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 6cd85d29fd 


Diff: https://reviews.apache.org/r/59615/diff/2/

Changes: https://reviews.apache.org/r/59615/diff/1-2/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 59615: HIVE-16778 LLAP IO: better refcount management

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59615/#review176238
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java
Lines 416 (patched)
<https://reviews.apache.org/r/59615/#comment249585>

    should not be moved


- Sergey Shelukhin


On May 27, 2017, 12:55 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59615/
> -----------------------------------------------------------
> 
> (Updated May 27, 2017, 12:55 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 969382681f 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReader.java ea9904ad7e 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 6cd85d29fd 
> 
> 
> Diff: https://reviews.apache.org/r/59615/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>