You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/12/07 10:48:44 UTC
[GitHub] [ratis] LiuJinghao opened a new pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
LiuJinghao opened a new pull request #556:
URL: https://github.com/apache/ratis/pull/556
## What changes were proposed in this pull request?
RaftServer started failed when rpc timeout use different unit.
The code analysis shows that the compareTo method of the TimeDuration class has a bug.
When the unit of this is greater than that, that.compareTo(this) is called, but the return value is not set to a negative value.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1462
## How was this patch tested?
unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] LiuJinghao removed a comment on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
LiuJinghao removed a comment on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988544776
这是一封自动回复邮件。已经收到您的来信，我会尽快回复。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #556:
URL: https://github.com/apache/ratis/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] LiuJinghao commented on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
LiuJinghao commented on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988644108
>
OK， I'll fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] LiuJinghao edited a comment on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
LiuJinghao edited a comment on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988644108
> @szetszwo
OK， I'll fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] LiuJinghao commented on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
LiuJinghao commented on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988544776
这是一封自动回复邮件。已经收到您的来信，我会尽快回复。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] LiuJinghao commented on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
LiuJinghao commented on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988649779
@szetszwo I‘ve fixed it and force pushed, please approval the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988601531
@LiuJinghao , there is a (false) findbugs warning RV_NEGATING_RESULT_OF_COMPARETO. Let's change the code as below to avoid the warning.
```
//TimeDuration.compareTo
return Integer.compare(0, that.compareTo(this));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] LiuJinghao removed a comment on pull request #556: RATIS-1462. RaftServer started failed when rpc timeout use different unit
Posted by GitBox <gi...@apache.org>.
LiuJinghao removed a comment on pull request #556:
URL: https://github.com/apache/ratis/pull/556#issuecomment-988644108
> @szetszwo
OK， I'll fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org