You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/31 05:11:17 UTC

[GitHub] [pinot] codecov-commenter commented on pull request #10821: Integrate `Obfuscator` for Minion tasks

codecov-commenter commented on PR #10821:
URL: https://github.com/apache/pinot/pull/10821#issuecomment-1569507693

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#10821](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cda2b02) into [master](https://app.codecov.io/gh/apache/pinot/commit/d8b78c3fb7d1138edf55a2b60bfd417b1794644f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d8b78c3) will **decrease** coverage by `56.53%`.
   > The diff coverage is `80.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #10821       +/-   ##
   =============================================
   - Coverage     70.17%   13.64%   -56.53%     
   + Complexity     6529      439     -6090     
   =============================================
     Files          2164     2110       -54     
     Lines        116408   113920     -2488     
     Branches      17609    17311      -298     
   =============================================
   - Hits          81686    15549    -66137     
   - Misses        29023    97104    +68081     
   + Partials       5699     1267     -4432     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `?` | |
   | integration2 | `?` | |
   | unittests1 | `?` | |
   | unittests2 | `13.64% <80.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/pinot/core/minion/PinotTaskConfig.java](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vUGlub3RUYXNrQ29uZmlnLmphdmE=) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
   | [.../pinot/minion/taskfactory/TaskFactoryRegistry.java](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vdGFza2ZhY3RvcnkvVGFza0ZhY3RvcnlSZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (-74.23%)` | :arrow_down: |
   | [...ion/tasks/mergerollup/MergeRollupTaskExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcGx1Z2lucy9waW5vdC1taW5pb24tdGFza3MvcGlub3QtbWluaW9uLWJ1aWx0aW4tdGFza3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3BsdWdpbi9taW5pb24vdGFza3MvbWVyZ2Vyb2xsdXAvTWVyZ2VSb2xsdXBUYXNrRXhlY3V0b3IuamF2YQ==) | `90.56% <100.00%> (-9.44%)` | :arrow_down: |
   | [...egments/RealtimeToOfflineSegmentsTaskExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcGx1Z2lucy9waW5vdC1taW5pb24tdGFza3MvcGlub3QtbWluaW9uLWJ1aWx0aW4tdGFza3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3BsdWdpbi9taW5pb24vdGFza3MvcmVhbHRpbWV0b29mZmxpbmVzZWdtZW50cy9SZWFsdGltZVRvT2ZmbGluZVNlZ21lbnRzVGFza0V4ZWN1dG9yLmphdmE=) | `71.42% <100.00%> (-23.24%)` | :arrow_down: |
   
   ... and [1708 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10821/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org