You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2016/05/04 00:12:12 UTC

[jira] [Updated] (HTRACE-359) TraceRunnable and TraceCallable should be built using parent spanId not scope

     [ https://issues.apache.org/jira/browse/HTRACE-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Drob updated HTRACE-359:
-----------------------------
    Attachment: HTRACE-359.v4.patch.txt

New patch that undoes most of the Tracer.java changes, adds public constructors that take SpanId to TraceRunnable and TraceCallable, and deprecates the existing TraceRunnable constructor.

> TraceRunnable and TraceCallable should be built using parent spanId not scope
> -----------------------------------------------------------------------------
>
>                 Key: HTRACE-359
>                 URL: https://issues.apache.org/jira/browse/HTRACE-359
>             Project: HTrace
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.0
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>         Attachments: HTRACE-359.patch.txt, HTRACE-359.patch.txt, HTRACE-359.v3.patch.txt, HTRACE-359.v4.patch.txt
>
>
> TraceRunnable/Callable both take a parent TraceScope and extract the span Id from it when executing the task. Instead, we should allow users to create custom TraceRunnable/Callable instances with only a SpanId instead of a full TraceScope, for instance when reading a span id from an RPC call and a TraceScope object is not available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)