You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "rangareddy (via GitHub)" <gi...@apache.org> on 2026/07/22 10:50:39 UTC
[PR] [730] Add required ASF navigation links to the website [incubator-xtable]
rangareddy opened a new pull request, #856:
URL: https://github.com/apache/incubator-xtable/pull/856
## What
Fixes the missing ASF-required navigation links flagged for the XTable website (the ones checked by the Incubator [Clutch report](https://incubator.apache.org/clutch/xtable.html)).
Closes #730
Per the [ASF project branding policy](https://www.apache.org/foundation/marks/pmcs#navigation), every project site must link to the Foundation home, License, Events, Sponsorship, Thanks, Security and Privacy. None of these were present.
## Changes
- **`website/docusaurus.config.js`** — add a `themeConfig.footer`. The site had no footer at all, so the docs/blog/community/releases pages carried none of the required links. The footer includes:
- an **Apache Software Foundation** column: Foundation, License, Events, Sponsorship, Thanks, Security, Privacy;
- an **XTable** column (Docs, Blogs, Downloads, Community, GitHub);
- the Apache Incubator logo and the podling incubation disclaimer + trademark/copyright notice.
- **`website/static/index.html`** — the home page is a static Webflow page that bypasses the Docusaurus theme, so it needs the links added directly. Added the same required ASF links to its footer (the incubation disclaimer + trademark notice were already present there).
## Required links added
| Link | URL |
|------|-----|
| Foundation | https://www.apache.org/ |
| License | https://www.apache.org/licenses/ |
| Events | https://www.apache.org/events/current-event |
| Sponsorship | https://www.apache.org/foundation/sponsorship.html |
| Thanks | https://www.apache.org/foundation/thanks.html |
| Security | https://www.apache.org/security/ |
| Privacy | https://privacy.apache.org/policies/privacy-policy-public.html |
## Testing
`node --check website/docusaurus.config.js` passes and the `footer` object was verified to load with both link columns and the copyright string intact. (Full `docusaurus build` requires installing the site's npm dependencies.)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [730] Add required ASF navigation links to the website [incubator-xtable]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on PR #856:
URL: https://github.com/apache/incubator-xtable/pull/856#issuecomment-5088145558
Hi @the-other-tim-brown
Addressed the review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [730] Add required ASF navigation links to the website [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown merged PR #856:
URL: https://github.com/apache/incubator-xtable/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [730] Add required ASF navigation links to the website [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on PR #856:
URL: https://github.com/apache/incubator-xtable/pull/856#issuecomment-5080223232
@rangareddy Can you include screenshots of the updates? Be sure to test the rendering on varying screen widths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [730] Add required ASF navigation links to the website [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #856:
URL: https://github.com/apache/incubator-xtable/pull/856#discussion_r3650865812
##########
website/docusaurus.config.js:
##########
@@ -89,6 +89,44 @@ const config = {
{to: 'community/sync', label: 'Community', position: 'left'}
],
},
+ footer: {
+ style: 'dark',
+ links: [
+ {
+ title: 'XTable',
+ items: [
+ {label: 'Docs', to: '/docs/setup/'},
+ {label: 'Blogs', to: '/blog'},
+ {label: 'Downloads', to: '/releases/downloads'},
+ {label: 'Community', to: '/community/sync'},
+ {label: 'GitHub', href: 'https://github.com/apache/incubator-xtable'},
+ ],
+ },
+ {
+ title: 'Apache Software Foundation',
+ items: [
+ {label: 'Foundation', href: 'https://www.apache.org/'},
+ {label: 'License', href: 'https://www.apache.org/licenses/'},
+ {label: 'Events', href: 'https://www.apache.org/events/current-event'},
+ {label: 'Sponsorship', href: 'https://www.apache.org/foundation/sponsorship.html'},
+ {label: 'Thanks', href: 'https://www.apache.org/foundation/thanks.html'},
+ {label: 'Security', href: 'https://www.apache.org/security/'},
+ {label: 'Privacy', href: 'https://privacy.apache.org/policies/privacy-policy-public.html'},
+ ],
+ },
+ ],
+ logo: {
+ alt: 'Apache Incubator',
+ src: 'https://www.apache.org/logos/res/incubator/incubator.png',
+ href: 'https://incubator.apache.org/',
+ width: 150,
+ },
+ copyright:
+ 'Apache XTable™ is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. ' +
Review Comment:
It looks like this is most similar to the "disclaimer" not a copyright.
The disclaimer should match the text on the ASF branding site: https://incubator.apache.org/guides/branding.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [730] Add required ASF navigation links to the website [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #856:
URL: https://github.com/apache/incubator-xtable/pull/856#discussion_r3650868962
##########
website/static/index.html:
##########
@@ -222,6 +222,15 @@ <h4 class="accordion-heading"><span><strong class="faq-q">How can I learn more?<
<a href="https://www.linkedin.com/company/apache-xtable/" class="footer-link-three">LinkedIn</a>
<a href="https://twitter.com/apachextable" class="footer-link-three l">Twitter</a>
</div>
+ <div class="footer-block-three">
+ <a href="https://www.apache.org/" class="footer-link-three" target="_blank" rel="noopener">Apache Software Foundation</a>
+ <a href="https://www.apache.org/licenses/" class="footer-link-three" target="_blank" rel="noopener">License</a>
+ <a href="https://www.apache.org/events/current-event" class="footer-link-three" target="_blank" rel="noopener">Events</a>
+ <a href="https://www.apache.org/foundation/sponsorship.html" class="footer-link-three" target="_blank" rel="noopener">Sponsorship</a>
+ <a href="https://www.apache.org/foundation/thanks.html" class="footer-link-three" target="_blank" rel="noopener">Thanks</a>
+ <a href="https://www.apache.org/security/" class="footer-link-three" target="_blank" rel="noopener">Security</a>
+ <a href="https://privacy.apache.org/policies/privacy-policy-public.html" class="footer-link-three l" target="_blank" rel="noopener">Privacy</a>
+ </div>
Review Comment:
Down on line 239, the copyright is still referencing 2025, can you update that as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org