You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/26 07:50:46 UTC
[GitHub] [openwhisk-runtime-deno] ningyougang opened a new pull request, #14: Support array result include sequence action
ningyougang opened a new pull request, #14:
URL: https://github.com/apache/openwhisk-runtime-deno/pull/14
Depend on below prs:
- https://github.com/apache/openwhisk/pull/5290 (If want to this pr's travis ci passed, should merge 5290 firstly)
- https://github.com/apache/openwhisk-runtime-go/pull/170 (because deno uses go runtime's actionProxy)
- [x] Support array result
- [x] make deno runtime to support array result for common action
- [x] make deno runtime to support array result for sequence action (support array as input param)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-deno] dgrove-oss merged pull request #14: Support array result include sequence action
Posted by GitBox <gi...@apache.org>.
dgrove-oss merged PR #14:
URL: https://github.com/apache/openwhisk-runtime-deno/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-deno] ningyougang commented on a diff in pull request #14: Support array result include sequence action
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #14:
URL: https://github.com/apache/openwhisk-runtime-deno/pull/14#discussion_r941955820
##########
deno1.3.0/Dockerfile:
##########
@@ -31,12 +31,12 @@ RUN curl -sL \
https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
| tar xzf -\
&& cd openwhisk-runtime-go-*/main\
- && GO111MODULE=on go build -o /bin/proxy
+ && GO111MODULE=on CGO_ENABLED=0 go build -o /bin/proxy
FROM hayd/alpine-deno:1.3.0
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review Comment:
Need to change it to `release` due to https://github.com/apache/openwhisk-runtime-java/pull/140#discussion_r939689436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-deno] ningyougang commented on a diff in pull request #14: Support array result include sequence action
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #14:
URL: https://github.com/apache/openwhisk-runtime-deno/pull/14#discussion_r945439332
##########
deno1.3.0/Dockerfile:
##########
@@ -31,12 +31,12 @@ RUN curl -sL \
https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
| tar xzf -\
&& cd openwhisk-runtime-go-*/main\
- && GO111MODULE=on go build -o /bin/proxy
+ && GO111MODULE=on CGO_ENABLED=0 go build -o /bin/proxy
FROM hayd/alpine-deno:1.3.0
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review Comment:
Aleady changed to `release`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org