You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/04/05 14:05:34 UTC

[GitHub] thrift pull request #1237: THRIFT-4166: fix recent VC2010 build regression a...

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1237

    THRIFT-4166: fix recent VC2010 build regression and prevent it in the future with appveyor

    I added a MSVC 2010, x86, debug, boost-1.54, python-2.7, qt-5.6 appveyor job to prevent this from happening again.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift THRIFT-4166

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1237
    
----
commit d8bfc0d0d283c38c918d10bd22b5a3391961a9b4
Author: James E. King, III <ji...@simplivity.com>
Date:   2017-04-04T19:30:32Z

    THRIFT-4166: fix recent VC2010 build regression and prevent it in the future

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1237: THRIFT-4166: fix recent VC2010 build regression and prev...

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1237
  
    Appveyor died due to an environmental error getting "ant" with chocolatey.  I have to do an empty commit and kick another one, but I'm going to wait until THRIFT-4071 so it isn't as expensive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1237: THRIFT-4166: fix recent VC2010 build regression a...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1237


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---