You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/18 08:56:44 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter
xiaoxiang781216 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525914316
##########
File path: libs/libc/audio/libsrc/0001-samplerate-define-package-and-version-for-NuttX-OS.patch
##########
@@ -0,0 +1,34 @@
+From 23d050a04e00d7029a619d235eda137dd3455ab2 Mon Sep 17 00:00:00 2001
+From: Alin Jerpelea <al...@sony.com>
+Date: Mon, 16 Nov 2020 09:43:35 +0100
+Subject: [PATCH 1/2] samplerate: define package and version for NuttX OS
+
+We have to define the PACKAGE and VERSION for NuttX OS.
+
+Signed-off-by: Alin Jerpelea <al...@sony.com>
+---
+ src/samplerate.h | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/src/samplerate.h b/src/samplerate.h
+index a3d5ae1..c1cfd6d 100644
+--- a/src/samplerate.h
++++ b/src/samplerate.h
+@@ -18,6 +18,15 @@
+ extern "C" {
+ #endif /* __cplusplus */
+
++/* Name of package */
++#ifndef PACKAGE
++#define PACKAGE "libsamplerate"
++#endif
++
++/* Version number of package */
++#ifndef VERSION
++#define VERSION "0.1.9"
++#endif
+
+ /* Opaque data type SRC_STATE. */
+ typedef struct SRC_STATE_tag SRC_STATE ;
Review comment:
why need this?
##########
File path: libs/libc/audio/libsrc/Make.defs
##########
@@ -0,0 +1,49 @@
+############################################################################
+# audio/libsrc/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifeq ($(CONFIG_AUDIO_SRC),y)
+
+libsamplerate:
+ $(Q) wget https://codeload.github.com/libsndfile/libsamplerate/zip/master -O libsamplerate.zip
Review comment:
should we use this download link instead?
https://github.com/libsndfile/libsamplerate/releases/download/v0.1.9/libsamplerate-0.1.9.tar.gz
##########
File path: libs/libc/audio/libsrc/Make.defs
##########
@@ -0,0 +1,49 @@
+############################################################################
+# audio/libsrc/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifeq ($(CONFIG_AUDIO_SRC),y)
+
+libsamplerate:
+ $(Q) wget https://codeload.github.com/libsndfile/libsamplerate/zip/master -O libsamplerate.zip
+ $(Q) unzip -o libsamplerate.zip
+ $(Q) mv libsamplerate-master libsamplerate
+ $(Q) patch -Np1 --verbose -d libsamplerate <audio/libsrc/0001-samplerate-define-package-and-version-for-NuttX-OS.patch
+ $(Q) patch -Np1 --verbose -d libsamplerate <audio/libsrc/0002-add-audio-quality-options.patch
+ $(Q) cp -rf libsamplerate/src/samplerate.h $(TOPDIR)$(DELIM)include$(DELIM)nuttx$(DELIM)audio$(DELIM)
+
+depend: libsamplerate
Review comment:
depend::?
##########
File path: libs/libc/includenuttxaudio
##########
@@ -0,0 +1,198 @@
+/*
+** Copyright (c) 2002-2016, Erik de Castro Lopo <er...@mega-nerd.com>
Review comment:
why need this file?
##########
File path: libs/libc/audio/libsrc/0001-samplerate-define-package-and-version-for-NuttX-OS.patch
##########
@@ -0,0 +1,34 @@
+From 23d050a04e00d7029a619d235eda137dd3455ab2 Mon Sep 17 00:00:00 2001
+From: Alin Jerpelea <al...@sony.com>
+Date: Mon, 16 Nov 2020 09:43:35 +0100
+Subject: [PATCH 1/2] samplerate: define package and version for NuttX OS
+
+We have to define the PACKAGE and VERSION for NuttX OS.
+
+Signed-off-by: Alin Jerpelea <al...@sony.com>
+---
+ src/samplerate.h | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+
+diff --git a/src/samplerate.h b/src/samplerate.h
+index a3d5ae1..c1cfd6d 100644
+--- a/src/samplerate.h
++++ b/src/samplerate.h
+@@ -18,6 +18,15 @@
+ extern "C" {
+ #endif /* __cplusplus */
+
++/* Name of package */
++#ifndef PACKAGE
++#define PACKAGE "libsamplerate"
Review comment:
we can pass PACKAGE and VERSION through -D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org