You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/21 21:09:16 UTC

[GitHub] [iceberg] krvikash opened a new pull request, #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

krvikash opened a new pull request, #6476:
URL: https://github.com/apache/iceberg/pull/6476

   API, Core, Flink, Parquet, Spark: Use enhanced for loop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] szehon-ho commented on pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

Posted by GitBox <gi...@apache.org>.
szehon-ho commented on PR #6476:
URL: https://github.com/apache/iceberg/pull/6476#issuecomment-1379333312

   Merged, thanks @krvikash , @hililiwei , @amogh-jahagirdar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] krvikash commented on pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

Posted by GitBox <gi...@apache.org>.
krvikash commented on PR #6476:
URL: https://github.com/apache/iceberg/pull/6476#issuecomment-1364003063

   > Good idea. The for-each loop gets rid of the clutter and the opportunity for error by hiding the iterator or index variable.
   
   Thanks, @hililiwei for reviewing. Addressed the comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] hililiwei commented on a diff in pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #6476:
URL: https://github.com/apache/iceberg/pull/6476#discussion_r1056343010


##########
core/src/jmh/java/org/apache/iceberg/util/ZOrderByteUtilsBenchmark.java:
##########
@@ -75,9 +75,8 @@ public void interleaveValuesFourColumns(Blackhole blackhole) {
     int outputSize = ZOrderByteUtils.PRIMITIVE_BUFFER_SIZE * 4;
     ByteBuffer outputBuffer = ByteBuffer.allocate(outputSize);
 
-    for (int i = 0; i < fourColumnInput.length; i++) {
-      byte[] interleavedBytes =
-          ZOrderByteUtils.interleaveBits(fourColumnInput[i], outputSize, outputBuffer);
+    for (byte[][] bytes : fourColumnInput) {

Review Comment:
   bytes -> columnsBinary



##########
core/src/jmh/java/org/apache/iceberg/util/ZOrderByteUtilsBenchmark.java:
##########
@@ -114,9 +113,8 @@ public void interleaveValuesFourColumns8ByteOutput(Blackhole blackhole) {
     int outputSize = 8;
     ByteBuffer outputBuffer = ByteBuffer.allocate(outputSize);
 
-    for (int i = 0; i < fourColumnInput.length; i++) {
-      byte[] interleavedBytes =
-          ZOrderByteUtils.interleaveBits(fourColumnInput[i], outputSize, outputBuffer);
+    for (byte[][] bytes : fourColumnInput) {

Review Comment:
   bytes -> columnsBinary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] szehon-ho merged pull request #6476: API, Core, Flink, Parquet, Spark: Use enhanced for loop

Posted by GitBox <gi...@apache.org>.
szehon-ho merged PR #6476:
URL: https://github.com/apache/iceberg/pull/6476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org