You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "martin-traverse (via GitHub)" <gi...@apache.org> on 2023/05/11 15:39:01 UTC

[GitHub] [arrow] martin-traverse opened a new issue, #35553: unwrap() in NettyArrowBuf causes breaks when debug / error messages are logged

martin-traverse opened a new issue, #35553:
URL: https://github.com/apache/arrow/issues/35553

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   The implementation of NettyArrowBuf unwrap() is throwing UnsupportedOperationException, but the ByteBuf interface says unwrap() should return null when a buffer cannot be unwrapped.  Netty's AbstractByteBuf base class calls unwrap() in toString() and prints extra info if the result is non-null. Since toString() is called every time a debug or error message is printed, real errors are getting masked and enabling debug logging is likely to cause unexpected errors.
   
   Seems like a simple fix just to return null from unwrap() in NettyArrowBuf? I will submit a PR with the change if someone wants to take a look.
   
   ### Component(s)
   
   Java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] martin-traverse commented on issue #35553: unwrap() in NettyArrowBuf causes breaks when debug / error messages are logged

Posted by "martin-traverse (via GitHub)" <gi...@apache.org>.

martin-traverse commented on issue #35553:
URL: https://github.com/apache/arrow/issues/35553#issuecomment-1544223912

   A couple of references
   * [ByteBuf unwrap()](https://github.com/netty/netty/blob/9fe796e10a433b6cd20ad78b2c39cd56b86ccd2e/buffer/src/main/java/io/netty/buffer/ByteBuf.java#L305)
   * [AbstractByteBuf toString()](https://github.com/netty/netty/blob/9fe796e10a433b6cd20ad78b2c39cd56b86ccd2e/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java#L1356)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed issue #35553: [Java] unwrap() in NettyArrowBuf causes breaks when debug / error messages are logged

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.

lidavidm closed issue #35553: [Java] unwrap() in NettyArrowBuf causes breaks when debug / error messages are logged
URL: https://github.com/apache/arrow/issues/35553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org