[GitHub] lebeg commented on a change in pull request #13338: Add CPU C++ test stage and fix CPU ACTIVATION_PERF.ExecuteBidirectional

[GitBox <gi...@apache.org>]

lebeg commented on a change in pull request #13338: Add CPU C++ test stage and fix CPU ACTIVATION_PERF.ExecuteBidirectional
URL: https://github.com/apache/incubator-mxnet/pull/13338#discussion_r235005635
 
 

 ##########
 File path: src/operator/nn/activation-inl.h
 ##########
 @@ -199,13 +199,8 @@ void ActivationGradCompute(const nnvm::NodeAttrs& attrs,
                            const std::vector<OpReqType>& req,
                            const std::vector<TBlob>& outputs) {
   const ActivationParam& param = nnvm::get<ActivationParam>(attrs.parsed);
-#if (MXNET_USE_CUDNN == 1 || MXNET_USE_MKLDNN == 1)
-  bool relu = param.act_type == activation::kReLU;
+  const bool relu = param.act_type == activation::kReLU;
   CHECK_EQ(inputs.size(), relu ? 2U : 3U);
 
 Review comment:
   This code was added in https://github.com/apache/incubator-mxnet/pull/11827 . Maybe @samskalicky can help here and say whether it's needed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services