You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/02 15:19:55 UTC
[GitHub] [maven-pmd-plugin] adangel opened a new pull request #31: [MPMD-304] - maven-pmd-plugin should be toolchains-aware
adangel opened a new pull request #31:
URL: https://github.com/apache/maven-pmd-plugin/pull/31
This PR adds toolchain support for PMD and CPD (see https://issues.apache.org/jira/browse/MPMD-304).
In order to do this, the following changes are made:
* Execution is now separated from PmdReport/CpdReport and moved to PmdExecutor/CpdExecutor
* The properties/parameter are handed over as PmdRequest/CpdRequest
* If a toolchain is in use, then PmdExecutor/CpdExecutor is called in a forked JVM. PmdRequest/CpdRequest is serialized/deserialized.
* The result is provided for reporting via PmdResult/CpdResult. These classes are just wrappers around the always created `target/pmd.xml` and `target/cpd.xml` files. So basically, PMD serializeds the result into these XML files, and m-pmd-p picks it up from there.
There are two possible incompatibilities:
* The public method `PmdReport.getPMDConfiguration()` is gone - the PMDConfiguration instance is created now by PmdExecutor and is not exposed anymore.
* `PmdReportGenerator` and `CpdReportGenerator` now work with the classes generated by m-pmd-p's generated modello classes instead of the PMD classes.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`,
where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel closed pull request #31: [MPMD-304] - maven-pmd-plugin should be toolchains-aware
Posted by GitBox <gi...@apache.org>.
adangel closed pull request #31:
URL: https://github.com/apache/maven-pmd-plugin/pull/31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org