[GitHub] jihoonson commented on a change in pull request #6629: Add support parallel combine in brokers

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6629: Add support parallel combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r239176626
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/QueryContexts.java
 ##########
 @@ -37,6 +37,8 @@
   public static final String DEFAULT_TIMEOUT_KEY = "defaultTimeout";
   @Deprecated
   public static final String CHUNK_PERIOD_KEY = "chunkPeriod";
+  public static final String NUM_BROKER_PARALLEL_COMBINE_THREADS = "numBrokerParallelCombineThreads";
 
 Review comment:
   Hmm, what is the most appropriate setting you are thinking? I guess it's possible to automatically pick something reasonable based on some statistics like intermediate aggregate size, # of rows to be combined, etc. This is possible in the future when we have a system to collect such statistics.
   
   It currently picks all available processing threads if this value is set to -1 (https://github.com/apache/incubator-druid/pull/6629/files#diff-d8ff07a1952a0070326e5647b4e738f9R45). Do you have a better idea?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org