You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/10 12:07:35 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6715: Add `trace_segment_ref_limit_per_span` configuration mechanism to avoid OOM

wu-sheng commented on a change in pull request #6715:
URL: https://github.com/apache/skywalking/pull/6715#discussion_r611037103



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -66,6 +66,12 @@
          */
         public static String IGNORE_SUFFIX = ".jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg";
 
+        /**
+         * The max number of TraceSegmentRef in a single span. Through this config item, SkyWalking keep your application
+         * memory cost estimated.

Review comment:
       ```suggestion
            * The max number of TraceSegmentRef in a single span to keep memory cost estimatable.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org