You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2019/12/10 12:51:00 UTC
[jira] [Commented] (PHOENIX-5465) Don't run checkstyle over
generated code
[ https://issues.apache.org/jira/browse/PHOENIX-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992517#comment-16992517 ]
Istvan Toth commented on PHOENIX-5465:
--------------------------------------
+1 LGTM
> Don't run checkstyle over generated code
> ----------------------------------------
>
> Key: PHOENIX-5465
> URL: https://issues.apache.org/jira/browse/PHOENIX-5465
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Attachments: PHOENIX-5465.001.patch
>
>
> In [~stoty]'s change over in PHOENIX-5428, I noticed that Checkstyle is set up to validate protobuf-generated code which is silly. We shouldn't apply checkstyle to our generated code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)