[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4630: [INLONG-4602][Manager] Remove the ClusterBean class

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4630:
URL: https://github.com/apache/incubator-inlong/pull/4630#discussion_r894993603


##########
inlong-manager/manager-web/src/main/resources/application-prod.properties:
##########
@@ -54,19 +54,10 @@ cluster.tube.master=127.0.0.1:8000,127.0.0.1:8010
 # Tube cluster ID
 cluster.tube.clusterId=1
 
-# Push configuration to the path on ZooKeeper
-cluster.zk.url=127.0.0.1:2181
-cluster.zk.root=inlong_hive
-
-# Application name in Sort
-sort.appName=inlong_app
-
 # Pulsar admin URL
 pulsar.adminUrl=http://127.0.0.1:8080,127.0.0.2:8080,127.0.0.3:8080

Review Comment:
   Please check if those Pulsar parameters are used. If not, it is recommended to delete it.



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/ConsumptionServiceImpl.java:
##########
@@ -418,6 +402,12 @@ private void fullConsumptionInfo(ConsumptionInfo info) {
                 streamTopics.forEach(stream -> topicSet.remove(stream.getMqResource()));
                 Preconditions.checkEmpty(topicSet, "topic [" + topicSet + "] not belong to inlong group " + groupId);
             }
+            InlongGroupEntity inlongGroupEntity = groupMapper.selectByGroupId(groupId);
+            if (null != inlongGroupEntity) {
+                info.setTopic(String.format(InlongGroupSettings.PULSAR_TOPIC_FORMAT, "public",

Review Comment:
   The default tenant is `public`, but before the default value, we should query from the cluster first.
   
   Please refer to the `InlongClusterService#getOne` to get more information.



##########
inlong-manager/manager-web/src/main/resources/application-prod.properties:
##########
@@ -54,19 +54,10 @@ cluster.tube.master=127.0.0.1:8000,127.0.0.1:8010
 # Tube cluster ID
 cluster.tube.clusterId=1

Review Comment:
   Please check if this parameter is used. If not, it is recommended to delete it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org