You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/11/05 04:03:36 UTC
[GitHub] incubator-guacamole-client pull request #74: GUACAMOLE-105: Clean up downloa...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/74
GUACAMOLE-105: Clean up download iframe only likely to be safe.
This change alters the `iframe` cleanup of `tunnelService.downloadStream()` to take place only after one of the following events:
1. The `load` event for the `iframe` fires (not all browsers do this, Chrome in particular).
2. A "reasonable" amount of time has elapsed after the stream has ended, and it is likely that the browser has finished saving the file (5 seconds).
Lacking these changes, it is possible that the `iframe` will be removed prior to the actual file save, thus causing the download to be canceled immediately upon completion.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client mitigate-iframe-timing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 92886e639d1aebdd3b3305e99d757ccf335281db
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-05T03:50:37Z
GUACAMOLE-105: Clean up download iframe only after download has truly completed. If completion cannot be determined, wait a reasonable amount of time before assuming completion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #74: GUACAMOLE-105: Clean up downloa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---