You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/08 13:04:42 UTC

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #11967: Fix getTopic may hangs

Demogorgon314 commented on a change in pull request #11967:
URL: https://github.com/apache/pulsar/pull/11967#discussion_r704397819



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2245,7 +2248,7 @@ private void createPendingLoadTopic() {
 
         final String topic = pendingTopic.getLeft();
         try {
-            checkTopicNsOwnership(topic);
+            checkTopicNsOwnership(topic).get();

Review comment:
       I don't think it is necessary. Because in https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/OwnershipCache.java#L267 already have timeout.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org