[GitHub] [spark] cloud-fan commented on a change in pull request #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r397626940
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
 ##########
 @@ -67,7 +67,7 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] {
    */
   private def isSkewed(size: Long, medianSize: Long): Boolean = {
     size > medianSize * conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_FACTOR) &&
-      size > conf.getConf(SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES)
+      size > conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_THRESHOLD)
 
 Review comment:
   now it's possible, if people set `SKEW_JOIN_SKEWED_PARTITION_THRESHOLD` much lower than `ADVISORY_PARTITION_SIZE_IN_BYTES`. But that's more like a malformed setting and we should simply ignore it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org