You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2024/04/11 17:17:29 UTC

[PR] Graph view improvements [airflow]

bbovenzi opened a new pull request, #38940:
URL: https://github.com/apache/airflow/pull/38940

   The text was getting cut off too many times for graph view nodes. The zoomed out version was also hard to read. 
   
   
   Before:
   <img width="420" alt="Screenshot 2024-04-11 at 1 14 15 PM" src="https://github.com/apache/airflow/assets/4600967/6c93cb8a-b970-4de0-b2ec-9310405f1dd7">
   <img width="805" alt="Screenshot 2024-04-11 at 1 14 10 PM" src="https://github.com/apache/airflow/assets/4600967/b995506d-d5db-49bd-ba27-c75d119d60c1">
   
   
   After:
   <img width="496" alt="Screenshot 2024-04-11 at 1 02 15 PM" src="https://github.com/apache/airflow/assets/4600967/f32302e0-dbd2-4e7b-9905-7b68f5b431cd">
   <img width="875" alt="Screenshot 2024-04-11 at 1 02 12 PM" src="https://github.com/apache/airflow/assets/4600967/bfe616cd-275a-420f-a680-35f39d847880">
   
   
   Two questions:
   - Should the simplified mode happen automatically when zooming out, or by toggling a checkbox?
   - What other information would people find useful to include in the details node view?
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Graph view improvements [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #38940:
URL: https://github.com/apache/airflow/pull/38940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Graph view improvements [airflow]

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #38940:
URL: https://github.com/apache/airflow/pull/38940#issuecomment-2059250510

   > Should the simplified mode happen automatically when zooming out, or by toggling a checkbox?
   
   I'd prefer zooming out vs introducing a toggle for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org