You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/09/30 13:40:02 UTC
[PR] fix(web): restore the About tab localization lost from trunk [rocketmq-dashboard]
123123213weqw opened a new pull request, #5233:
URL: https://github.com/apache/rocketmq-dashboard/pull/5233
### Which Issue(s) This PR Fixes
Fixes #5221
### Brief Description
#4803 (merged) localized the About tab, but a later branch fold carried the component back to its pre-localization copy: the labels render hardcoded Chinese again and the nine `settings.about*` keys are gone from the translation table. This restores the `t()` wiring and the keys on top of the current content values (3.0.0, Spring Boot 4.1) and re-adds the identity-`t` test so a fold cannot silently drop them again.
### How Did You Test This Change
`npx vitest run src/pages/settings/__tests__/AboutTab.test.tsx src/pages/settings/__tests__/SettingsPage.test.tsx` — 3/3 green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): restore the About tab localization lost from trunk [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5233: fix(web): restore the About tab localization lost from trunk
URL: https://github.com/apache/rocketmq-dashboard/pull/5233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): restore the About tab localization lost from trunk [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5233:
URL: https://github.com/apache/rocketmq-dashboard/pull/5233#issuecomment-6049502087
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): restore the About tab localization lost from trunk [rocketmq-dashboard]
Posted by "123123213weqw (via GitHub)" <gi...@apache.org>.
123123213weqw commented on PR #5233:
URL: https://github.com/apache/rocketmq-dashboard/pull/5233#issuecomment-6135055319
Continued in #6481 per the path you outlined: the description is corrected (#4803 was stale-closed, never merged-and-reverted — my earlier claim was wrong), the change is credited to @Wang1rrr via a Co-authored-by trailer, and the branch is rebased onto the current `rocketmq-studio`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): restore the About tab localization lost from trunk [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5233:
URL: https://github.com/apache/rocketmq-dashboard/pull/5233#issuecomment-6074066360
This pull request was closed by the stale bot on 2026-10-08 (seven days without activity), not by a maintainer decision - the review below is what we had queued for it.
The code itself passes every gate we apply: the nine hardcoded Chinese strings are real, the keys line up with the dictionary, trunk's translations test already guards key existence, the branch merges cleanly against `rocketmq-studio`, and the three cases the description lists are the three the file has.
Two things have to be settled first:
1. The description says #4803 was merged and later reverted by a branch fold. That is not what happened - #4803 (by @Wang1rrr) was never merged; the stale bot closed it. This branch is a near-verbatim resubmission of it. Please correct the description and the test comment, and say how the change came to you (rebased from the closed PR, or written independently).
2. Until that is settled we cannot merge it. Two byte-level identical patches from different authors, one of them closed by a bot, is exactly the case where taking the wrong one misattributes somebody's work.
If you are in touch with the original author, the cleanest path is a single pull request that credits both of you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org