You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/10 05:37:36 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1577: Add in hive3 and hive-runtime to autolabeler configuration
kbendick opened a new pull request #1577:
URL: https://github.com/apache/iceberg/pull/1577
The autolabeler is currently configured mostly off of top level names, either directories or files, with an exception for some infra and build related things.
The iceberg-hive module was split into multiple modules. This updates the `/hive3` and `/hive-runtime` to be labeled as hive. It also closes https://github.com/apache/iceberg/issues/1574
I've chosen to add a new label, METASTORE, for the newer `hive-metastore` because it is of importance to several other projects. That's handled in this PR: https://github.com/apache/iceberg/pull/1576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1577: Add in hive3 and hive-runtime to autolabeler configuration
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1577:
URL: https://github.com/apache/iceberg/pull/1577#issuecomment-706492294
Now that I think about it, whether or not we introduce an additional label for `METASTORE`, this project is of importance to those amongst us who are take special interest in hive related code changes. I'm going to add `hive-metastore` to the `HIVE` tag and possibly also leave up the open PR for adding it to a new label `METASTORE` as well.
What I'd really like is to be able to add a label such as `CATALOG`, which would capture all of the catalog and metastore related changes. Additionally, I'd love to see a label for `InputFomat` related changes. But for now, as I don't have the time at the moment to take on a major change of the labeling system as I've got a few other open issues, I'll add these to keep things up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1577: Add split up hive modules to the autolabeler configuration
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1577:
URL: https://github.com/apache/iceberg/pull/1577#issuecomment-706627297
Thanks, @kbendick!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1577: Add split up hive modules to the autolabeler configuration
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1577:
URL: https://github.com/apache/iceberg/pull/1577#issuecomment-706621293
cc @rdblue for this simple change to the autolabeler and also your thoughts on this change as well https://github.com/apache/iceberg/pull/1576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1577: Add split up hive modules to the autolabeler configuration
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1577:
URL: https://github.com/apache/iceberg/pull/1577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org