You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2023/04/14 05:59:25 UTC
[GitHub] [doris] CalvinKirs opened a new pull request, #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
CalvinKirs opened a new pull request, #18666:
URL: https://github.com/apache/doris/pull/18666
# Proposed changes
Issue Number: close #xxx
## Problem summary
`commons-lang `(1and2) is no longer maintained since 2011, and the official recommendation is `commons-lang3`, which can be smoothly upgraded to be compatible with `commons-lang`.
We use both dependencies in `fe`, which can be completely unified.
`PatternGenerator#generateTypePattern `has many meaningless loops, and IntegerRange is introduced for, which is unnecessary. So I refactored it.
## Describe your changes.
- Use commons-lang3 uniformly
- Add the check that prohibits commons-lang in checkstyle
- Refactor PatternGenerator#generateTypePattern to reduce meaningless method loops
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #18666:
URL: https://github.com/apache/doris/pull/18666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #18666:
URL: https://github.com/apache/doris/pull/18666#issuecomment-1507965740
todo add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #18666:
URL: https://github.com/apache/doris/pull/18666#issuecomment-1508634746
The multiple loop in the PatternGenerator#generateTypePattern is for readability, this function will invoke in the compile time so is not the hot point.
Maybe we should use `java.util.stream.IntStream.range()` to replace it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #18666:
URL: https://github.com/apache/doris/pull/18666#issuecomment-1510299251
> I know, I just replace `IntegerRange`,but even with the current approach, I don't think it has increased the complexity of the code. right?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #18666:
URL: https://github.com/apache/doris/pull/18666#issuecomment-1508612598
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #18666:
URL: https://github.com/apache/doris/pull/18666#issuecomment-1510637913
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #18666: [Improve](fe)Use commons-lang3 uniformly and refactor PatternGenerator#generateTypePattern
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #18666:
URL: https://github.com/apache/doris/pull/18666#issuecomment-1510010170
> The multiple loop in the PatternGenerator#generateTypePattern is for readability, this function will invoke in the compile time so is not the hot point.↳
I know, I just replace `IntegerRange`,but even with the current approach, I don't think it has increased the complexity of the code. right?
>
> Maybe we should use `java.util.stream.IntStream.rangeClosed()` to replace the `IntRange`↳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org