You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/06/18 01:25:57 UTC

svn commit: r1493972 - /commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java

Author: sebb
Date: Mon Jun 17 23:25:57 2013
New Revision: 1493972

URL: http://svn.apache.org/r1493972
Log:
Javadocs

Modified:
    commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java

Modified: commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java
URL: http://svn.apache.org/viewvc/commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java?rev=1493972&r1=1493971&r2=1493972&view=diff
==============================================================================
--- commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java (original)
+++ commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java Mon Jun 17 23:25:57 2013
@@ -45,12 +45,16 @@ public class DigestMojo extends Abstract
 
     /**
      * List of files to include, default none.
+     * Standard Maven wildard patterns apply.
+     * Patterns are assumed to be relative to the project base directory.
      */
     @Parameter
     private Set<String> includes;
 
     /**
      * List of files to exclude, default none.
+     * Standard Maven wildard patterns apply.
+     * Patterns are assumed to be relative to the project base directory.
      */
     @Parameter
     private Set<String> excludes;
@@ -58,6 +62,7 @@ public class DigestMojo extends Abstract
     /**
      * List of files to include, comma-separated (intended for command-line usage).
      * Overrides includes and excludes; uses same syntax as for {@code <include>}
+     * Patterns are assumed to be relative to the project base directory.
      */
     @Parameter (property="digest.files")
     private String files;
@@ -133,7 +138,7 @@ public class DigestMojo extends Abstract
     private String[]  scanForSources() {
         DirectoryScanner ds = new DirectoryScanner();
         ds.setFollowSymlinks( true );
-        ds.setBasedir( project.getBasedir() );
+        ds.setBasedir( project.getBasedir() ); // Cannot be omitted; implies that includes/excludes are relative
         String[] inc;
         if (files != null) { // Overrides includes / excludes
             getLog().debug("files="+files);



Re: svn commit: r1493972 - /commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java

Posted by sebb <se...@gmail.com>.
On 18 June 2013 03:36, Bruno P. Kinoshita <br...@yahoo.com.br> wrote:
> Hi sebb,
>
> I think there's a small typo in the Javadocs?
>
> s/wildard/wildcard/

Indeed, fixed, thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1493972 - /commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java

Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br>.
Hi sebb, 

I think there's a small typo in the Javadocs?

s/wildard/wildcard/

Cheers

Bruno

>________________________________
> From: "sebb@apache.org" <se...@apache.org>
>To: commits@commons.apache.org 
>Sent: Monday, June 17, 2013 8:25 PM
>Subject: svn commit: r1493972 - /commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java
> 
>
>Author: sebb
>Date: Mon Jun 17 23:25:57 2013
>New Revision: 1493972
>
>URL: http://svn.apache.org/r1493972
>Log:
>Javadocs
>
>Modified:
>    commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java
>
>Modified: commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java
>URL: http://svn.apache.org/viewvc/commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java?rev=1493972&r1=1493971&r2=1493972&view=diff
>==============================================================================
>--- commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java (original)
>+++ commons/sandbox/commons-digest-plugin/trunk/src/main/java/org/apache/commons/plugins/digest/DigestMojo.java Mon Jun 17 23:25:57 2013
>@@ -45,12 +45,16 @@ public class DigestMojo extends Abstract
>
>     /**
>      * List of files to include, default none.
>+     * Standard Maven wildard patterns apply.
>+     * Patterns are assumed to be relative to the project base directory.
>      */
>     @Parameter
>     private Set<String> includes;
>
>     /**
>      * List of files to exclude, default none.
>+     * Standard Maven wildard patterns apply.
>+     * Patterns are assumed to be relative to the project base directory.
>      */
>     @Parameter
>     private Set<String> excludes;
>@@ -58,6 +62,7 @@ public class DigestMojo extends Abstract
>     /**
>      * List of files to include, comma-separated (intended for command-line usage).
>      * Overrides includes and excludes; uses same syntax as for {@code <include>}
>+     * Patterns are assumed to be relative to the project base directory.
>      */
>     @Parameter (property="digest.files")
>     private String files;
>@@ -133,7 +138,7 @@ public class DigestMojo extends Abstract
>     private String[]  scanForSources() {
>         DirectoryScanner ds = new DirectoryScanner();
>         ds.setFollowSymlinks( true );
>-        ds.setBasedir( project.getBasedir() );
>+        ds.setBasedir( project.getBasedir() ); // Cannot be omitted; implies that includes/excludes are relative
>         String[] inc;
>         if (files != null) { // Overrides includes / excludes
>             getLog().debug("files="+files);
>
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org