You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:53:48 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3244: feat(cli): reduce binary size by 1/3
squakez opened a new pull request, #3244:
URL: https://github.com/apache/camel-k/pull/3244
Adding -s and -w flag reduce significatively the size of the output (52 vs 73 MiB)
```
$ ll kamel -h
-rwxrwxr-x 1 squake squake 73M abr 28 16:47 kamel*
```
vs
```
$ ll kamel -h
-rwxrwxr-x 1 squake squake 52M abr 28 16:50 kamel*
```
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(cli): reduce binary size by 1/3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3244:
URL: https://github.com/apache/camel-k/pull/3244#issuecomment-1116495257
It seems these flags just remove debugging information from the final binary file. So if developers want to debug kamel or operator binary, these flags should not be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
astefanutti commented on PR #3244:
URL: https://github.com/apache/camel-k/pull/3244#issuecomment-1122033509
@squakez thanks for this proposal.
On one hand, removing the debug symbol is probably acceptable.
On the other hand, for the operator part, what really matters IMO is the size of the container image, which reduces/dilutes the benefit of these flags. For the CLI part of the binary, it seems providing a CLI only binary would be an even better solution, size-wise, granted it's more work than adding some build flags.
It's not clear to me what are the consequences of the `-s` flag.
Last but not least, I haven't seen these flags being used in other projects, but maybe I overlooked it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3244:
URL: https://github.com/apache/camel-k/pull/3244#issuecomment-1208753228
This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3244:
URL: https://github.com/apache/camel-k/pull/3244#issuecomment-1118398626
@astefanutti what do you think about this possible improvements? do you have any familiarity with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] closed pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3244: feat(cli): reduce binary size by 1/3
URL: https://github.com/apache/camel-k/pull/3244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3244:
URL: https://github.com/apache/camel-k/pull/3244#issuecomment-1117027043
> It seems these flags just remove debugging information from the final binary file. So if developers want to debug kamel or operator binary, these flags should not be used.
Thanks for having a look. The meaning of those flags can be found here: https://pkg.go.dev/cmd/link .I am not sure how much of that information is actually used by our troubleshooting operations. I made some test and, apparently, we still manage to get the error traces. Actually I don't know what we really loose in order to measure the tradeoff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3244: feat(cli): reduce binary size by 1/3
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3244:
URL: https://github.com/apache/camel-k/pull/3244#issuecomment-1122139328
Thanks for the review @astefanutti. Yeah, I don't have much experience on golang projects, reason why I was asking your review. I agree about the opportunity to reduce the CLI size only (see #3175), but in the while, I wonder if we can try experimenting with this and collect feedback (complains!?). Reverting the change would be quick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org