You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/01/22 21:36:14 UTC
[GitHub] codecov-io commented on issue #142: LIVY-552 Add JWTFilter to
validate incoming JWT tokens
codecov-io commented on issue #142: LIVY-552 Add JWTFilter to validate incoming JWT tokens
URL: https://github.com/apache/incubator-livy/pull/142#issuecomment-456572678
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=h1) Report
> Merging [#142](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/02550f7919b7348b6a7270cf806e031670037b2f?src=pr&el=desc) will **increase** coverage by `0.28%`.
> The diff coverage is `71.87%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #142 +/- ##
============================================
+ Coverage 68.34% 68.62% +0.28%
- Complexity 895 913 +18
============================================
Files 100 103 +3
Lines 5604 5664 +60
Branches 840 848 +8
============================================
+ Hits 3830 3887 +57
+ Misses 1225 1220 -5
- Partials 549 557 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `37.11% <0%> (-0.59%)` | `11 <0> (ø)` | |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `95.91% <100%> (+0.06%)` | `21 <0> (ø)` | :arrow_down: |
| [...n/scala/org/apache/livy/server/jwt/JWTFilter.scala](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvand0L0pXVEZpbHRlci5zY2FsYQ==) | `66.66% <66.66%> (ø)` | `6 <6> (?)` | |
| [...cala/org/apache/livy/server/jwt/JWTValidator.scala](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvand0L0pXVFZhbGlkYXRvci5zY2FsYQ==) | `85.71% <85.71%> (ø)` | `9 <9> (?)` | |
| [...g/apache/livy/server/jwt/JWSVerifierProvider.scala](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvand0L0pXU1ZlcmlmaWVyUHJvdmlkZXIuc2NhbGE=) | `93.75% <93.75%> (ø)` | `5 <5> (?)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `77.96% <0%> (-1.28%)` | `41% <0%> (-1%)` | |
| [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `66.01% <0%> (+1.94%)` | `13% <0%> (ø)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-livy/pull/142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=footer). Last update [02550f7...101a6e2](https://codecov.io/gh/apache/incubator-livy/pull/142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services