You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Mark Combellack (JIRA)" <tu...@ws.apache.org> on 2007/10/08 17:01:03 UTC

[jira] Created: (TUSCANY-1836) JMS Binding does not conform to the specification when creating JMS queues

JMS Binding does not conform to the specification when creating JMS queues
--------------------------------------------------------------------------

                 Key: TUSCANY-1836
                 URL: https://issues.apache.org/jira/browse/TUSCANY-1836
             Project: Tuscany
          Issue Type: Bug
          Components: Java SCA JMS Binding Extension
    Affects Versions: Java-SCA-1.0
         Environment: SVN Revision #582742
Linux
            Reporter: Mark Combellack
            Priority: Minor
             Fix For: Java-SCA-Next


Currently, the way that the JMS Binding creates JMS queues is not compliant with the SCA JMS Binding specification.

Currently it looks for the JMS Queue. If it does not exist, it will attempt to create it if the create mode is CREATE_ALLWAYS.


The JMS Binding specification says: 

137    • /binding.jms/destination/@create - indicates whether the destination should be created
138    when the containing composite is deployed. Valid values are "always", "never" and
139    "ifnotexist". The default value is "ifnotexist". If "always" is specified and the corresponding
140    resource already exists, then this should be considered an error.


The current implementation does not handle the following scenarios correctly:

   * Queue existing and "always" specified
   * No support for "ifnotexist"


Also, throughout the code CREATE_ALLWAYS is spelt wrongly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1836) JMS Binding does not conform to the specification when creating JMS queues

Posted by "Mark Combellack (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Combellack updated TUSCANY-1836:
-------------------------------------

    Attachment: JMSQueueCreateModes_Tests.patch
                JMSQueueCreateModes.patch

The patch JMSQueueCreateModes.patch updates the JMS binding to make it specification compliant in the way it creates it's JMS queues

The patch JMSQueueCreateModes_Tests.patch adds unit tests for the various queue creation scenarios.

> JMS Binding does not conform to the specification when creating JMS queues
> --------------------------------------------------------------------------
>
>                 Key: TUSCANY-1836
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1836
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-1.0
>         Environment: SVN Revision #582742
> Linux
>            Reporter: Mark Combellack
>            Priority: Minor
>             Fix For: Java-SCA-Next
>
>         Attachments: JMSQueueCreateModes.patch, JMSQueueCreateModes_Tests.patch
>
>
> Currently, the way that the JMS Binding creates JMS queues is not compliant with the SCA JMS Binding specification.
> Currently it looks for the JMS Queue. If it does not exist, it will attempt to create it if the create mode is CREATE_ALLWAYS.
> The JMS Binding specification says: 
> 137    • /binding.jms/destination/@create - indicates whether the destination should be created
> 138    when the containing composite is deployed. Valid values are "always", "never" and
> 139    "ifnotexist". The default value is "ifnotexist". If "always" is specified and the corresponding
> 140    resource already exists, then this should be considered an error.
> The current implementation does not handle the following scenarios correctly:
>    * Queue existing and "always" specified
>    * No support for "ifnotexist"
> Also, throughout the code CREATE_ALLWAYS is spelt wrongly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Assigned: (TUSCANY-1836) JMS Binding does not conform to the specification when creating JMS queues

Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws reassigned TUSCANY-1836:
-----------------------------------

    Assignee: Simon Laws

> JMS Binding does not conform to the specification when creating JMS queues
> --------------------------------------------------------------------------
>
>                 Key: TUSCANY-1836
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1836
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-1.0
>         Environment: SVN Revision #582742
> Linux
>            Reporter: Mark Combellack
>            Assignee: Simon Laws
>            Priority: Minor
>             Fix For: Java-SCA-Next
>
>         Attachments: JMSQueueCreateModes.patch, JMSQueueCreateModes_Tests.patch
>
>
> Currently, the way that the JMS Binding creates JMS queues is not compliant with the SCA JMS Binding specification.
> Currently it looks for the JMS Queue. If it does not exist, it will attempt to create it if the create mode is CREATE_ALLWAYS.
> The JMS Binding specification says: 
> 137    • /binding.jms/destination/@create - indicates whether the destination should be created
> 138    when the containing composite is deployed. Valid values are "always", "never" and
> 139    "ifnotexist". The default value is "ifnotexist". If "always" is specified and the corresponding
> 140    resource already exists, then this should be considered an error.
> The current implementation does not handle the following scenarios correctly:
>    * Queue existing and "always" specified
>    * No support for "ifnotexist"
> Also, throughout the code CREATE_ALLWAYS is spelt wrongly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1836) JMS Binding does not conform to the specification when creating JMS queues

Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws updated TUSCANY-1836:
--------------------------------

    Fix Version/s:     (was: Java-SCA-Next)
                   Java-SCA-1.1

Assing to 1.1

> JMS Binding does not conform to the specification when creating JMS queues
> --------------------------------------------------------------------------
>
>                 Key: TUSCANY-1836
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1836
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-1.0
>         Environment: SVN Revision #582742
> Linux
>            Reporter: Mark Combellack
>            Assignee: Simon Laws
>            Priority: Minor
>             Fix For: Java-SCA-1.1
>
>         Attachments: JMSQueueCreateModes.patch, JMSQueueCreateModes_Tests.patch
>
>
> Currently, the way that the JMS Binding creates JMS queues is not compliant with the SCA JMS Binding specification.
> Currently it looks for the JMS Queue. If it does not exist, it will attempt to create it if the create mode is CREATE_ALLWAYS.
> The JMS Binding specification says: 
> 137    • /binding.jms/destination/@create - indicates whether the destination should be created
> 138    when the containing composite is deployed. Valid values are "always", "never" and
> 139    "ifnotexist". The default value is "ifnotexist". If "always" is specified and the corresponding
> 140    resource already exists, then this should be considered an error.
> The current implementation does not handle the following scenarios correctly:
>    * Queue existing and "always" specified
>    * No support for "ifnotexist"
> Also, throughout the code CREATE_ALLWAYS is spelt wrongly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-1836) JMS Binding does not conform to the specification when creating JMS queues

Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws resolved TUSCANY-1836.
---------------------------------

    Resolution: Fixed

Thanks for the patch Mark. I've just applied it. 

> JMS Binding does not conform to the specification when creating JMS queues
> --------------------------------------------------------------------------
>
>                 Key: TUSCANY-1836
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1836
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>    Affects Versions: Java-SCA-1.0
>         Environment: SVN Revision #582742
> Linux
>            Reporter: Mark Combellack
>            Assignee: Simon Laws
>            Priority: Minor
>             Fix For: Java-SCA-Next
>
>         Attachments: JMSQueueCreateModes.patch, JMSQueueCreateModes_Tests.patch
>
>
> Currently, the way that the JMS Binding creates JMS queues is not compliant with the SCA JMS Binding specification.
> Currently it looks for the JMS Queue. If it does not exist, it will attempt to create it if the create mode is CREATE_ALLWAYS.
> The JMS Binding specification says: 
> 137    • /binding.jms/destination/@create - indicates whether the destination should be created
> 138    when the containing composite is deployed. Valid values are "always", "never" and
> 139    "ifnotexist". The default value is "ifnotexist". If "always" is specified and the corresponding
> 140    resource already exists, then this should be considered an error.
> The current implementation does not handle the following scenarios correctly:
>    * Queue existing and "always" specified
>    * No support for "ifnotexist"
> Also, throughout the code CREATE_ALLWAYS is spelt wrongly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org