You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/06/05 01:28:43 UTC

DO NOT REPLY [Bug 51323] New: Svn property fixes

https://issues.apache.org/bugzilla/show_bug.cgi?id=51323

             Bug #: 51323
           Summary: Svn property fixes
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org
    Classification: Unclassified


Created attachment 27113
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27113
Script to fix SVN properties

Attached file fixes some SVN property errors in TOMCAT_7_0_15 (and presumably
trunk).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51323] Svn property fixes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51323

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> 2011-06-06 10:12:16 UTC ---
Fixed in r1132569: svn:eol-style on TesterAccessLogValve.java

Regarding the rest of the patch that sets svn:keywords property on the files in
/java/org/apache/tomcat/util/bcel/classfile/ -- it is wrong. None of those
files uses any keywords. Thus there is no need to set this property there.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 51323] Svn property fixes

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51323

--- Comment #2 from Sebb <se...@apache.org> 2011-06-06 14:37:06 UTC ---
My checking script detected that the wrong syntax was used for the
svn:keywords.

The keywords are currently set to

"Author Date Id Revision"

rather than the correct

Author Date Id Revision

The leading and trailing quotes should not be present, as they stop Author and
Revision keywords from working (if present).

It's confusing to have the invalid keywords in the propery, so I suggest that
the properties are fixed or deleted.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org