[GitHub] [arrow] benibus commented on a diff in pull request #36334: GH-15281: [C++] Replace bytes_view alias with span

["benibus (via GitHub)" <gi...@apache.org>]

benibus commented on code in PR #36334:
URL: https://github.com/apache/arrow/pull/36334#discussion_r1247159503


##########
cpp/src/arrow/util/bitmap.h:
##########
@@ -387,10 +384,10 @@ class ARROW_EXPORT Bitmap : public util::ToStringOstreamable<Bitmap>,
   int64_t length() const { return length_; }
 
   /// string_view of all bytes which contain any bit in this Bitmap

Review Comment:
   Maybe we should alter these method comments now? e.g:
   ```suggestion
     /// span of all bytes which contain any bit in this Bitmap
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org