[GitHub] [tinkerpop] nastra commented on issue #1120: gt/gte/lt/lte can throw CCE if object isn't a Comparable

[GitBox <gi...@apache.org>]

nastra commented on issue #1120: gt/gte/lt/lte can throw CCE if object isn't a Comparable
URL: https://github.com/apache/tinkerpop/pull/1120#issuecomment-496592225
 
 
   IMO having the CCE is the worst choice of all and it rather indicates a programming error rather than wrong input from users. 
   
   I would suggest that we add a precondition check that makes sure both objects are either a `Number` or a `Comparable`, since that's essentially what the code expects. If not, we throw an exception telling the user that only `Number` /  `Comparable` can be used.
   
   wdyt @spmallette / @dkuppitz ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services