You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Parth Chandra <pa...@apache.org> on 2016/08/02 04:40:44 UTC
Time for a 1.8 release
Hi Everyone,
I think its time to roll out 1.8. Would any PMC member/committer like
to volunteer to be the release manager?
Parth
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
Just a reminder that if you want to include
work-in-progress/under-review patch in 1.8 release, please reply to
this email and get it reviewed asap. The tentative cut-off day is
Monday.
On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com> wrote:
> I would like to propose we set Monday 8/8 as the tentative cut-off
> date for 1.8 release.
>
> If people have any working-in-progress patches, and would like to
> include in 1.8 release, please submit PR, or ping people to review
> your PR if there has been a PR under review.
>
> Thanks,
>
>
>
>
> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
>> Hello everyone,
>>
>> I would like to start the train for 1.8 release.
>>
>> If you have been working on some open issues, and want to include
>> them in 1.8, please rely this email and let us know the JIRAs number
>> and corresponding pull requests.
>>
>> Based on the response, we may go through the list of opens JIRAs for
>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>>
>> Thanks,
>>
>>
>>
>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>>> +1 for Jinfeng as the RM for 1.8 release.
>>>
>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>>
>>>> I'll volunteer to be the release manager for 1.8, if no one else would
>>>> like to do so.
>>>>
>>>>
>>>>
>>>>
>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>>>> > Hi Everyone,
>>>> >
>>>> > I think its time to roll out 1.8. Would any PMC member/committer
>>>> like
>>>> > to volunteer to be the release manager?
>>>> >
>>>> > Parth
>>>>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
Both DRILL-4836 and DRILL-4766 were merged. I'll start to build the
release today.
On Tue, Aug 9, 2016 at 9:40 AM, Zelaine Fong <zf...@maprtech.com> wrote:
> Looks like DRILL-4795 also got pushed this morning.
>
> I haven't seen a pull request for DRILL-4836, so I assume that one is still
> pending.
>
> What about DRILL-4766? I see a +1 on that pull request, but don't think
> this has been pushed.
>
> -- Zelaine
>
> -- Zelaine
>
>
>
> On Mon, Aug 8, 2016 at 9:08 PM, Jinfeng Ni <ji...@gmail.com> wrote:
>
>> Here is the latest status of 1.8.0 release.
>>
>> (venki) DRILL-4732, DRILL-4729, DRILL-4728 : merged
>> (sudheesh) DRILL-4822, DRILL-4819, DRILL-4623 : merged
>> DRILL-4792 : not merged.
>>
>> DRILL-4836 was opened just now, which seems to be a regression from
>> several release back. I think it would make sense to try to get
>> DRILL-4836 fixed in this release.
>>
>> I'll also try to merge Dave's DRILL-4704 tonight.
>>
>>
>> On Fri, Aug 5, 2016 at 1:35 PM, Venki Korukanti
>> <ve...@gmail.com> wrote:
>> > I will try to get these sometime today or eod tomorrow.
>> >
>> > 1) DRILL-4728: Add support for new metadata fetch APIs,
>> > https://github.com/apache/drill/pull/527 (Ready to commit after few
>> minor
>> > changes)
>> >
>> > 2) DRILL-4729: Add support for prepared statement API on server side,
>> > https://github.com/apache/drill/pull/530 (need to address a review
>> comment)
>> >
>> > 3) DRILL-4732: Update JDBC driver to use new prepared statement API in
>> > DrillClient, https://github.com/apache/drill/pull/532 (need to address a
>> > comment).
>> >
>> > Thanks
>> > Venki
>> >
>> > On Fri, Aug 5, 2016 at 1:31 PM, Sudheesh Katkam <sk...@maprtech.com>
>> > wrote:
>> >
>> >> Yes, that’s a typo. DRILL-3623 was for LIMIT 0 changes. That number will
>> >> forever remain in my subconscious ;)
>> >>
>> >> Thank you,
>> >> Sudheesh
>> >>
>> >> > On Aug 5, 2016, at 1:27 PM, Zelaine Fong <zf...@maprtech.com> wrote:
>> >> >
>> >> > I assume #3 has a typo. It should be DRILL-4623.
>> >> >
>> >> > -- Zelaine
>> >> >
>> >> > On Fri, Aug 5, 2016 at 1:15 PM, Sudheesh Katkam <su...@apache.org>
>> >> wrote:
>> >> >
>> >> >> Here’s my list that I will try to get in before Monday.
>> >> >>
>> >> >> 1) DRILL-4822: Pending commit.
>> >> >> PR: https://github.com/apache/drill/pull/558
>> >> >>
>> >> >> 2) DRILL-4819: Pending review from Aditya.
>> >> >> PR: https://github.com/apache/drill/pull/556
>> >> >>
>> >> >> 3) DRILL-3623: Pending tests (or test results).
>> >> >> PR: https://github.com/apache/drill/pull/486
>> >> >>
>> >> >> 4) DRILL-4792: Pending changes from Arina.
>> >> >> PR: https://github.com/apache/drill/pull/551
>> >> >>
>> >> >> The first three will make it; the last one may not.
>> >> >>
>> >> >> Thank you,
>> >> >> Sudheesh
>> >> >>
>> >> >>
>> >> >> On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com>
>> >> wrote:
>> >> >>
>> >> >>> I would like to propose we set Monday 8/8 as the tentative cut-off
>> >> >>> date for 1.8 release.
>> >> >>>
>> >> >>> If people have any working-in-progress patches, and would like to
>> >> >>> include in 1.8 release, please submit PR, or ping people to review
>> >> >>> your PR if there has been a PR under review.
>> >> >>>
>> >> >>> Thanks,
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com>
>> >> >> wrote:
>> >> >>>> Hello everyone,
>> >> >>>>
>> >> >>>> I would like to start the train for 1.8 release.
>> >> >>>>
>> >> >>>> If you have been working on some open issues, and want to include
>> >> >>>> them in 1.8, please rely this email and let us know the JIRAs
>> number
>> >> >>>> and corresponding pull requests.
>> >> >>>>
>> >> >>>> Based on the response, we may go through the list of opens JIRAs
>> for
>> >> >>>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>> >> >>>>
>> >> >>>> Thanks,
>> >> >>>>
>> >> >>>>
>> >> >>>>
>> >> >>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>> >> >>>>> +1 for Jinfeng as the RM for 1.8 release.
>> >> >>>>>
>> >> >>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <
>> jinfengni99@gmail.com>
>> >> >>> wrote:
>> >> >>>>>
>> >> >>>>>> I'll volunteer to be the release manager for 1.8, if no one else
>> >> >> would
>> >> >>>>>> like to do so.
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <parthc@apache.org
>> >
>> >> >>> wrote:
>> >> >>>>>>> Hi Everyone,
>> >> >>>>>>>
>> >> >>>>>>> I think its time to roll out 1.8. Would any PMC
>> >> >> member/committer
>> >> >>>>>> like
>> >> >>>>>>> to volunteer to be the release manager?
>> >> >>>>>>>
>> >> >>>>>>> Parth
>> >> >>>>>>
>> >> >>>
>> >> >>
>> >>
>> >>
>>
Re: Time for a 1.8 release
Posted by Zelaine Fong <zf...@maprtech.com>.
Looks like DRILL-4795 also got pushed this morning.
I haven't seen a pull request for DRILL-4836, so I assume that one is still
pending.
What about DRILL-4766? I see a +1 on that pull request, but don't think
this has been pushed.
-- Zelaine
-- Zelaine
On Mon, Aug 8, 2016 at 9:08 PM, Jinfeng Ni <ji...@gmail.com> wrote:
> Here is the latest status of 1.8.0 release.
>
> (venki) DRILL-4732, DRILL-4729, DRILL-4728 : merged
> (sudheesh) DRILL-4822, DRILL-4819, DRILL-4623 : merged
> DRILL-4792 : not merged.
>
> DRILL-4836 was opened just now, which seems to be a regression from
> several release back. I think it would make sense to try to get
> DRILL-4836 fixed in this release.
>
> I'll also try to merge Dave's DRILL-4704 tonight.
>
>
> On Fri, Aug 5, 2016 at 1:35 PM, Venki Korukanti
> <ve...@gmail.com> wrote:
> > I will try to get these sometime today or eod tomorrow.
> >
> > 1) DRILL-4728: Add support for new metadata fetch APIs,
> > https://github.com/apache/drill/pull/527 (Ready to commit after few
> minor
> > changes)
> >
> > 2) DRILL-4729: Add support for prepared statement API on server side,
> > https://github.com/apache/drill/pull/530 (need to address a review
> comment)
> >
> > 3) DRILL-4732: Update JDBC driver to use new prepared statement API in
> > DrillClient, https://github.com/apache/drill/pull/532 (need to address a
> > comment).
> >
> > Thanks
> > Venki
> >
> > On Fri, Aug 5, 2016 at 1:31 PM, Sudheesh Katkam <sk...@maprtech.com>
> > wrote:
> >
> >> Yes, that’s a typo. DRILL-3623 was for LIMIT 0 changes. That number will
> >> forever remain in my subconscious ;)
> >>
> >> Thank you,
> >> Sudheesh
> >>
> >> > On Aug 5, 2016, at 1:27 PM, Zelaine Fong <zf...@maprtech.com> wrote:
> >> >
> >> > I assume #3 has a typo. It should be DRILL-4623.
> >> >
> >> > -- Zelaine
> >> >
> >> > On Fri, Aug 5, 2016 at 1:15 PM, Sudheesh Katkam <su...@apache.org>
> >> wrote:
> >> >
> >> >> Here’s my list that I will try to get in before Monday.
> >> >>
> >> >> 1) DRILL-4822: Pending commit.
> >> >> PR: https://github.com/apache/drill/pull/558
> >> >>
> >> >> 2) DRILL-4819: Pending review from Aditya.
> >> >> PR: https://github.com/apache/drill/pull/556
> >> >>
> >> >> 3) DRILL-3623: Pending tests (or test results).
> >> >> PR: https://github.com/apache/drill/pull/486
> >> >>
> >> >> 4) DRILL-4792: Pending changes from Arina.
> >> >> PR: https://github.com/apache/drill/pull/551
> >> >>
> >> >> The first three will make it; the last one may not.
> >> >>
> >> >> Thank you,
> >> >> Sudheesh
> >> >>
> >> >>
> >> >> On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com>
> >> wrote:
> >> >>
> >> >>> I would like to propose we set Monday 8/8 as the tentative cut-off
> >> >>> date for 1.8 release.
> >> >>>
> >> >>> If people have any working-in-progress patches, and would like to
> >> >>> include in 1.8 release, please submit PR, or ping people to review
> >> >>> your PR if there has been a PR under review.
> >> >>>
> >> >>> Thanks,
> >> >>>
> >> >>>
> >> >>>
> >> >>>
> >> >>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com>
> >> >> wrote:
> >> >>>> Hello everyone,
> >> >>>>
> >> >>>> I would like to start the train for 1.8 release.
> >> >>>>
> >> >>>> If you have been working on some open issues, and want to include
> >> >>>> them in 1.8, please rely this email and let us know the JIRAs
> number
> >> >>>> and corresponding pull requests.
> >> >>>>
> >> >>>> Based on the response, we may go through the list of opens JIRAs
> for
> >> >>>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
> >> >>>>
> >> >>>> Thanks,
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
> >> >>>>> +1 for Jinfeng as the RM for 1.8 release.
> >> >>>>>
> >> >>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <
> jinfengni99@gmail.com>
> >> >>> wrote:
> >> >>>>>
> >> >>>>>> I'll volunteer to be the release manager for 1.8, if no one else
> >> >> would
> >> >>>>>> like to do so.
> >> >>>>>>
> >> >>>>>>
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <parthc@apache.org
> >
> >> >>> wrote:
> >> >>>>>>> Hi Everyone,
> >> >>>>>>>
> >> >>>>>>> I think its time to roll out 1.8. Would any PMC
> >> >> member/committer
> >> >>>>>> like
> >> >>>>>>> to volunteer to be the release manager?
> >> >>>>>>>
> >> >>>>>>> Parth
> >> >>>>>>
> >> >>>
> >> >>
> >>
> >>
>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
Here is the latest status of 1.8.0 release.
(venki) DRILL-4732, DRILL-4729, DRILL-4728 : merged
(sudheesh) DRILL-4822, DRILL-4819, DRILL-4623 : merged
DRILL-4792 : not merged.
DRILL-4836 was opened just now, which seems to be a regression from
several release back. I think it would make sense to try to get
DRILL-4836 fixed in this release.
I'll also try to merge Dave's DRILL-4704 tonight.
On Fri, Aug 5, 2016 at 1:35 PM, Venki Korukanti
<ve...@gmail.com> wrote:
> I will try to get these sometime today or eod tomorrow.
>
> 1) DRILL-4728: Add support for new metadata fetch APIs,
> https://github.com/apache/drill/pull/527 (Ready to commit after few minor
> changes)
>
> 2) DRILL-4729: Add support for prepared statement API on server side,
> https://github.com/apache/drill/pull/530 (need to address a review comment)
>
> 3) DRILL-4732: Update JDBC driver to use new prepared statement API in
> DrillClient, https://github.com/apache/drill/pull/532 (need to address a
> comment).
>
> Thanks
> Venki
>
> On Fri, Aug 5, 2016 at 1:31 PM, Sudheesh Katkam <sk...@maprtech.com>
> wrote:
>
>> Yes, that’s a typo. DRILL-3623 was for LIMIT 0 changes. That number will
>> forever remain in my subconscious ;)
>>
>> Thank you,
>> Sudheesh
>>
>> > On Aug 5, 2016, at 1:27 PM, Zelaine Fong <zf...@maprtech.com> wrote:
>> >
>> > I assume #3 has a typo. It should be DRILL-4623.
>> >
>> > -- Zelaine
>> >
>> > On Fri, Aug 5, 2016 at 1:15 PM, Sudheesh Katkam <su...@apache.org>
>> wrote:
>> >
>> >> Here’s my list that I will try to get in before Monday.
>> >>
>> >> 1) DRILL-4822: Pending commit.
>> >> PR: https://github.com/apache/drill/pull/558
>> >>
>> >> 2) DRILL-4819: Pending review from Aditya.
>> >> PR: https://github.com/apache/drill/pull/556
>> >>
>> >> 3) DRILL-3623: Pending tests (or test results).
>> >> PR: https://github.com/apache/drill/pull/486
>> >>
>> >> 4) DRILL-4792: Pending changes from Arina.
>> >> PR: https://github.com/apache/drill/pull/551
>> >>
>> >> The first three will make it; the last one may not.
>> >>
>> >> Thank you,
>> >> Sudheesh
>> >>
>> >>
>> >> On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com>
>> wrote:
>> >>
>> >>> I would like to propose we set Monday 8/8 as the tentative cut-off
>> >>> date for 1.8 release.
>> >>>
>> >>> If people have any working-in-progress patches, and would like to
>> >>> include in 1.8 release, please submit PR, or ping people to review
>> >>> your PR if there has been a PR under review.
>> >>>
>> >>> Thanks,
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com>
>> >> wrote:
>> >>>> Hello everyone,
>> >>>>
>> >>>> I would like to start the train for 1.8 release.
>> >>>>
>> >>>> If you have been working on some open issues, and want to include
>> >>>> them in 1.8, please rely this email and let us know the JIRAs number
>> >>>> and corresponding pull requests.
>> >>>>
>> >>>> Based on the response, we may go through the list of opens JIRAs for
>> >>>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>> >>>>
>> >>>> Thanks,
>> >>>>
>> >>>>
>> >>>>
>> >>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>> >>>>> +1 for Jinfeng as the RM for 1.8 release.
>> >>>>>
>> >>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com>
>> >>> wrote:
>> >>>>>
>> >>>>>> I'll volunteer to be the release manager for 1.8, if no one else
>> >> would
>> >>>>>> like to do so.
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org>
>> >>> wrote:
>> >>>>>>> Hi Everyone,
>> >>>>>>>
>> >>>>>>> I think its time to roll out 1.8. Would any PMC
>> >> member/committer
>> >>>>>> like
>> >>>>>>> to volunteer to be the release manager?
>> >>>>>>>
>> >>>>>>> Parth
>> >>>>>>
>> >>>
>> >>
>>
>>
Re: Time for a 1.8 release
Posted by Venki Korukanti <ve...@gmail.com>.
I will try to get these sometime today or eod tomorrow.
1) DRILL-4728: Add support for new metadata fetch APIs,
https://github.com/apache/drill/pull/527 (Ready to commit after few minor
changes)
2) DRILL-4729: Add support for prepared statement API on server side,
https://github.com/apache/drill/pull/530 (need to address a review comment)
3) DRILL-4732: Update JDBC driver to use new prepared statement API in
DrillClient, https://github.com/apache/drill/pull/532 (need to address a
comment).
Thanks
Venki
On Fri, Aug 5, 2016 at 1:31 PM, Sudheesh Katkam <sk...@maprtech.com>
wrote:
> Yes, that’s a typo. DRILL-3623 was for LIMIT 0 changes. That number will
> forever remain in my subconscious ;)
>
> Thank you,
> Sudheesh
>
> > On Aug 5, 2016, at 1:27 PM, Zelaine Fong <zf...@maprtech.com> wrote:
> >
> > I assume #3 has a typo. It should be DRILL-4623.
> >
> > -- Zelaine
> >
> > On Fri, Aug 5, 2016 at 1:15 PM, Sudheesh Katkam <su...@apache.org>
> wrote:
> >
> >> Here’s my list that I will try to get in before Monday.
> >>
> >> 1) DRILL-4822: Pending commit.
> >> PR: https://github.com/apache/drill/pull/558
> >>
> >> 2) DRILL-4819: Pending review from Aditya.
> >> PR: https://github.com/apache/drill/pull/556
> >>
> >> 3) DRILL-3623: Pending tests (or test results).
> >> PR: https://github.com/apache/drill/pull/486
> >>
> >> 4) DRILL-4792: Pending changes from Arina.
> >> PR: https://github.com/apache/drill/pull/551
> >>
> >> The first three will make it; the last one may not.
> >>
> >> Thank you,
> >> Sudheesh
> >>
> >>
> >> On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com>
> wrote:
> >>
> >>> I would like to propose we set Monday 8/8 as the tentative cut-off
> >>> date for 1.8 release.
> >>>
> >>> If people have any working-in-progress patches, and would like to
> >>> include in 1.8 release, please submit PR, or ping people to review
> >>> your PR if there has been a PR under review.
> >>>
> >>> Thanks,
> >>>
> >>>
> >>>
> >>>
> >>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com>
> >> wrote:
> >>>> Hello everyone,
> >>>>
> >>>> I would like to start the train for 1.8 release.
> >>>>
> >>>> If you have been working on some open issues, and want to include
> >>>> them in 1.8, please rely this email and let us know the JIRAs number
> >>>> and corresponding pull requests.
> >>>>
> >>>> Based on the response, we may go through the list of opens JIRAs for
> >>>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
> >>>>
> >>>> Thanks,
> >>>>
> >>>>
> >>>>
> >>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
> >>>>> +1 for Jinfeng as the RM for 1.8 release.
> >>>>>
> >>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com>
> >>> wrote:
> >>>>>
> >>>>>> I'll volunteer to be the release manager for 1.8, if no one else
> >> would
> >>>>>> like to do so.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org>
> >>> wrote:
> >>>>>>> Hi Everyone,
> >>>>>>>
> >>>>>>> I think its time to roll out 1.8. Would any PMC
> >> member/committer
> >>>>>> like
> >>>>>>> to volunteer to be the release manager?
> >>>>>>>
> >>>>>>> Parth
> >>>>>>
> >>>
> >>
>
>
Re: Time for a 1.8 release
Posted by Sudheesh Katkam <sk...@maprtech.com>.
Yes, that’s a typo. DRILL-3623 was for LIMIT 0 changes. That number will forever remain in my subconscious ;)
Thank you,
Sudheesh
> On Aug 5, 2016, at 1:27 PM, Zelaine Fong <zf...@maprtech.com> wrote:
>
> I assume #3 has a typo. It should be DRILL-4623.
>
> -- Zelaine
>
> On Fri, Aug 5, 2016 at 1:15 PM, Sudheesh Katkam <su...@apache.org> wrote:
>
>> Here’s my list that I will try to get in before Monday.
>>
>> 1) DRILL-4822: Pending commit.
>> PR: https://github.com/apache/drill/pull/558
>>
>> 2) DRILL-4819: Pending review from Aditya.
>> PR: https://github.com/apache/drill/pull/556
>>
>> 3) DRILL-3623: Pending tests (or test results).
>> PR: https://github.com/apache/drill/pull/486
>>
>> 4) DRILL-4792: Pending changes from Arina.
>> PR: https://github.com/apache/drill/pull/551
>>
>> The first three will make it; the last one may not.
>>
>> Thank you,
>> Sudheesh
>>
>>
>> On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>
>>> I would like to propose we set Monday 8/8 as the tentative cut-off
>>> date for 1.8 release.
>>>
>>> If people have any working-in-progress patches, and would like to
>>> include in 1.8 release, please submit PR, or ping people to review
>>> your PR if there has been a PR under review.
>>>
>>> Thanks,
>>>
>>>
>>>
>>>
>>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com>
>> wrote:
>>>> Hello everyone,
>>>>
>>>> I would like to start the train for 1.8 release.
>>>>
>>>> If you have been working on some open issues, and want to include
>>>> them in 1.8, please rely this email and let us know the JIRAs number
>>>> and corresponding pull requests.
>>>>
>>>> Based on the response, we may go through the list of opens JIRAs for
>>>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>>>>
>>>> Thanks,
>>>>
>>>>
>>>>
>>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>>>>> +1 for Jinfeng as the RM for 1.8 release.
>>>>>
>>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com>
>>> wrote:
>>>>>
>>>>>> I'll volunteer to be the release manager for 1.8, if no one else
>> would
>>>>>> like to do so.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org>
>>> wrote:
>>>>>>> Hi Everyone,
>>>>>>>
>>>>>>> I think its time to roll out 1.8. Would any PMC
>> member/committer
>>>>>> like
>>>>>>> to volunteer to be the release manager?
>>>>>>>
>>>>>>> Parth
>>>>>>
>>>
>>
Re: Time for a 1.8 release
Posted by Zelaine Fong <zf...@maprtech.com>.
I assume #3 has a typo. It should be DRILL-4623.
-- Zelaine
On Fri, Aug 5, 2016 at 1:15 PM, Sudheesh Katkam <su...@apache.org> wrote:
> Here’s my list that I will try to get in before Monday.
>
> 1) DRILL-4822: Pending commit.
> PR: https://github.com/apache/drill/pull/558
>
> 2) DRILL-4819: Pending review from Aditya.
> PR: https://github.com/apache/drill/pull/556
>
> 3) DRILL-3623: Pending tests (or test results).
> PR: https://github.com/apache/drill/pull/486
>
> 4) DRILL-4792: Pending changes from Arina.
> PR: https://github.com/apache/drill/pull/551
>
> The first three will make it; the last one may not.
>
> Thank you,
> Sudheesh
>
>
> On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>
> > I would like to propose we set Monday 8/8 as the tentative cut-off
> > date for 1.8 release.
> >
> > If people have any working-in-progress patches, and would like to
> > include in 1.8 release, please submit PR, or ping people to review
> > your PR if there has been a PR under review.
> >
> > Thanks,
> >
> >
> >
> >
> > On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com>
> wrote:
> > > Hello everyone,
> > >
> > > I would like to start the train for 1.8 release.
> > >
> > > If you have been working on some open issues, and want to include
> > > them in 1.8, please rely this email and let us know the JIRAs number
> > > and corresponding pull requests.
> > >
> > > Based on the response, we may go through the list of opens JIRAs for
> > > 1.8, and come up with a tentatively cut-off date for 1.8 release.
> > >
> > > Thanks,
> > >
> > >
> > >
> > > On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
> > >> +1 for Jinfeng as the RM for 1.8 release.
> > >>
> > >> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com>
> > wrote:
> > >>
> > >>> I'll volunteer to be the release manager for 1.8, if no one else
> would
> > >>> like to do so.
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org>
> > wrote:
> > >>> > Hi Everyone,
> > >>> >
> > >>> > I think its time to roll out 1.8. Would any PMC
> member/committer
> > >>> like
> > >>> > to volunteer to be the release manager?
> > >>> >
> > >>> > Parth
> > >>>
> >
>
Re: Time for a 1.8 release
Posted by Sudheesh Katkam <su...@apache.org>.
Here’s my list that I will try to get in before Monday.
1) DRILL-4822: Pending commit.
PR: https://github.com/apache/drill/pull/558
2) DRILL-4819: Pending review from Aditya.
PR: https://github.com/apache/drill/pull/556
3) DRILL-3623: Pending tests (or test results).
PR: https://github.com/apache/drill/pull/486
4) DRILL-4792: Pending changes from Arina.
PR: https://github.com/apache/drill/pull/551
The first three will make it; the last one may not.
Thank you,
Sudheesh
On Wed, Aug 3, 2016 at 11:49 AM, Jinfeng Ni <ji...@gmail.com> wrote:
> I would like to propose we set Monday 8/8 as the tentative cut-off
> date for 1.8 release.
>
> If people have any working-in-progress patches, and would like to
> include in 1.8 release, please submit PR, or ping people to review
> your PR if there has been a PR under review.
>
> Thanks,
>
>
>
>
> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
> > Hello everyone,
> >
> > I would like to start the train for 1.8 release.
> >
> > If you have been working on some open issues, and want to include
> > them in 1.8, please rely this email and let us know the JIRAs number
> > and corresponding pull requests.
> >
> > Based on the response, we may go through the list of opens JIRAs for
> > 1.8, and come up with a tentatively cut-off date for 1.8 release.
> >
> > Thanks,
> >
> >
> >
> > On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
> >> +1 for Jinfeng as the RM for 1.8 release.
> >>
> >> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com>
> wrote:
> >>
> >>> I'll volunteer to be the release manager for 1.8, if no one else would
> >>> like to do so.
> >>>
> >>>
> >>>
> >>>
> >>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org>
> wrote:
> >>> > Hi Everyone,
> >>> >
> >>> > I think its time to roll out 1.8. Would any PMC member/committer
> >>> like
> >>> > to volunteer to be the release manager?
> >>> >
> >>> > Parth
> >>>
>
RE: Time for a 1.8 release
Posted by Dave Oshinsky <do...@commvault.com>.
Jinfeng,
Please see my new commit & comment in PR 517.
I attached debugger to Drill and found it's passing through line 172 (not 315-316) of ExpressionTreeMaterializer.java, and that the "toType" object is one of those runtime generated ones (name like TypeProtos$MajorType@8570). Rather than attempt to change that code, I made another change to CastIntDecimal.java which avoids repeated calculation of the precision when it is already provided. Please review.
Dave Oshinsky
-----Original Message-----
From: Jinfeng Ni [mailto:jinfengni99@gmail.com]
Sent: Wednesday, August 03, 2016 7:18 PM
To: dev
Subject: Re: Time for a 1.8 release
I put a comment in PR 517.
On Wed, Aug 3, 2016 at 3:09 PM, Jinfeng Ni <ji...@gmail.com> wrote:
> Although decimal type is listed as alpha feature for Drill[1] and not
> recommend for production use, it is important to fix the incorrect
> issues such as the one reported in DRILL-4704.
>
> Let me take a quick look at your PR and see if it's ready to be merged.
>
> [1] https://drill.apache.org/docs/supported-data-types/
>
>
> On Wed, Aug 3, 2016 at 11:55 AM, Dave Oshinsky <do...@commvault.com> wrote:
>> Can we try to get this one (in play since shortly before 1.7 release) into 1.8?
>> https://github.com/apache/drill/pull/517
>>
>> Aman Sinha was reviewing it, but that seemed to stall. As a general question, is there any priority on making decimal types work better? If yes, a DRILL-4704 fix would be a very small start.
>>
>> Dave Oshinsky
>>
>> -----Original Message-----
>> From: Jinfeng Ni [mailto:jinfengni99@gmail.com]
>> Sent: Wednesday, August 03, 2016 2:49 PM
>> To: dev
>> Subject: Re: Time for a 1.8 release
>>
>> I would like to propose we set Monday 8/8 as the tentative cut-off date for 1.8 release.
>>
>> If people have any working-in-progress patches, and would like to include in 1.8 release, please submit PR, or ping people to review your PR if there has been a PR under review.
>>
>> Thanks,
>>
>>
>>
>>
>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
>>> Hello everyone,
>>>
>>> I would like to start the train for 1.8 release.
>>>
>>> If you have been working on some open issues, and want to include
>>> them in 1.8, please rely this email and let us know the JIRAs number
>>> and corresponding pull requests.
>>>
>>> Based on the response, we may go through the list of opens JIRAs
>>> for 1.8, and come up with a tentatively cut-off date for 1.8 release.
>>>
>>> Thanks,
>>>
>>>
>>>
>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>>>> +1 for Jinfeng as the RM for 1.8 release.
>>>>
>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>>>
>>>>> I'll volunteer to be the release manager for 1.8, if no one else
>>>>> would like to do so.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>>>>> > Hi Everyone,
>>>>> >
>>>>> > I think its time to roll out 1.8. Would any PMC
>>>>> > member/committer
>>>>> like
>>>>> > to volunteer to be the release manager?
>>>>> >
>>>>> > Parth
>>>>>
>>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
I put a comment in PR 517.
On Wed, Aug 3, 2016 at 3:09 PM, Jinfeng Ni <ji...@gmail.com> wrote:
> Although decimal type is listed as alpha feature for Drill[1] and not
> recommend for production use, it is important to fix the incorrect
> issues such as the one reported in DRILL-4704.
>
> Let me take a quick look at your PR and see if it's ready to be merged.
>
> [1] https://drill.apache.org/docs/supported-data-types/
>
>
> On Wed, Aug 3, 2016 at 11:55 AM, Dave Oshinsky <do...@commvault.com> wrote:
>> Can we try to get this one (in play since shortly before 1.7 release) into 1.8?
>> https://github.com/apache/drill/pull/517
>>
>> Aman Sinha was reviewing it, but that seemed to stall. As a general question, is there any priority on making decimal types work better? If yes, a DRILL-4704 fix would be a very small start.
>>
>> Dave Oshinsky
>>
>> -----Original Message-----
>> From: Jinfeng Ni [mailto:jinfengni99@gmail.com]
>> Sent: Wednesday, August 03, 2016 2:49 PM
>> To: dev
>> Subject: Re: Time for a 1.8 release
>>
>> I would like to propose we set Monday 8/8 as the tentative cut-off date for 1.8 release.
>>
>> If people have any working-in-progress patches, and would like to include in 1.8 release, please submit PR, or ping people to review your PR if there has been a PR under review.
>>
>> Thanks,
>>
>>
>>
>>
>> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
>>> Hello everyone,
>>>
>>> I would like to start the train for 1.8 release.
>>>
>>> If you have been working on some open issues, and want to include
>>> them in 1.8, please rely this email and let us know the JIRAs number
>>> and corresponding pull requests.
>>>
>>> Based on the response, we may go through the list of opens JIRAs for
>>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>>>
>>> Thanks,
>>>
>>>
>>>
>>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>>>> +1 for Jinfeng as the RM for 1.8 release.
>>>>
>>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>>>
>>>>> I'll volunteer to be the release manager for 1.8, if no one else
>>>>> would like to do so.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>>>>> > Hi Everyone,
>>>>> >
>>>>> > I think its time to roll out 1.8. Would any PMC
>>>>> > member/committer
>>>>> like
>>>>> > to volunteer to be the release manager?
>>>>> >
>>>>> > Parth
>>>>>
>>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
Although decimal type is listed as alpha feature for Drill[1] and not
recommend for production use, it is important to fix the incorrect
issues such as the one reported in DRILL-4704.
Let me take a quick look at your PR and see if it's ready to be merged.
[1] https://drill.apache.org/docs/supported-data-types/
On Wed, Aug 3, 2016 at 11:55 AM, Dave Oshinsky <do...@commvault.com> wrote:
> Can we try to get this one (in play since shortly before 1.7 release) into 1.8?
> https://github.com/apache/drill/pull/517
>
> Aman Sinha was reviewing it, but that seemed to stall. As a general question, is there any priority on making decimal types work better? If yes, a DRILL-4704 fix would be a very small start.
>
> Dave Oshinsky
>
> -----Original Message-----
> From: Jinfeng Ni [mailto:jinfengni99@gmail.com]
> Sent: Wednesday, August 03, 2016 2:49 PM
> To: dev
> Subject: Re: Time for a 1.8 release
>
> I would like to propose we set Monday 8/8 as the tentative cut-off date for 1.8 release.
>
> If people have any working-in-progress patches, and would like to include in 1.8 release, please submit PR, or ping people to review your PR if there has been a PR under review.
>
> Thanks,
>
>
>
>
> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
>> Hello everyone,
>>
>> I would like to start the train for 1.8 release.
>>
>> If you have been working on some open issues, and want to include
>> them in 1.8, please rely this email and let us know the JIRAs number
>> and corresponding pull requests.
>>
>> Based on the response, we may go through the list of opens JIRAs for
>> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>>
>> Thanks,
>>
>>
>>
>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>>> +1 for Jinfeng as the RM for 1.8 release.
>>>
>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>>
>>>> I'll volunteer to be the release manager for 1.8, if no one else
>>>> would like to do so.
>>>>
>>>>
>>>>
>>>>
>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>>>> > Hi Everyone,
>>>> >
>>>> > I think its time to roll out 1.8. Would any PMC
>>>> > member/committer
>>>> like
>>>> > to volunteer to be the release manager?
>>>> >
>>>> > Parth
>>>>
>
RE: Time for a 1.8 release
Posted by Dave Oshinsky <do...@commvault.com>.
Can we try to get this one (in play since shortly before 1.7 release) into 1.8?
https://github.com/apache/drill/pull/517
Aman Sinha was reviewing it, but that seemed to stall. As a general question, is there any priority on making decimal types work better? If yes, a DRILL-4704 fix would be a very small start.
Dave Oshinsky
-----Original Message-----
From: Jinfeng Ni [mailto:jinfengni99@gmail.com]
Sent: Wednesday, August 03, 2016 2:49 PM
To: dev
Subject: Re: Time for a 1.8 release
I would like to propose we set Monday 8/8 as the tentative cut-off date for 1.8 release.
If people have any working-in-progress patches, and would like to include in 1.8 release, please submit PR, or ping people to review your PR if there has been a PR under review.
Thanks,
On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
> Hello everyone,
>
> I would like to start the train for 1.8 release.
>
> If you have been working on some open issues, and want to include
> them in 1.8, please rely this email and let us know the JIRAs number
> and corresponding pull requests.
>
> Based on the response, we may go through the list of opens JIRAs for
> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>
> Thanks,
>
>
>
> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>> +1 for Jinfeng as the RM for 1.8 release.
>>
>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>
>>> I'll volunteer to be the release manager for 1.8, if no one else
>>> would like to do so.
>>>
>>>
>>>
>>>
>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>>> > Hi Everyone,
>>> >
>>> > I think its time to roll out 1.8. Would any PMC
>>> > member/committer
>>> like
>>> > to volunteer to be the release manager?
>>> >
>>> > Parth
>>>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
I would like to propose we set Monday 8/8 as the tentative cut-off
date for 1.8 release.
If people have any working-in-progress patches, and would like to
include in 1.8 release, please submit PR, or ping people to review
your PR if there has been a PR under review.
Thanks,
On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <ji...@gmail.com> wrote:
> Hello everyone,
>
> I would like to start the train for 1.8 release.
>
> If you have been working on some open issues, and want to include
> them in 1.8, please rely this email and let us know the JIRAs number
> and corresponding pull requests.
>
> Based on the response, we may go through the list of opens JIRAs for
> 1.8, and come up with a tentatively cut-off date for 1.8 release.
>
> Thanks,
>
>
>
> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
>> +1 for Jinfeng as the RM for 1.8 release.
>>
>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>>
>>> I'll volunteer to be the release manager for 1.8, if no one else would
>>> like to do so.
>>>
>>>
>>>
>>>
>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>>> > Hi Everyone,
>>> >
>>> > I think its time to roll out 1.8. Would any PMC member/committer
>>> like
>>> > to volunteer to be the release manager?
>>> >
>>> > Parth
>>>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
Hello everyone,
I would like to start the train for 1.8 release.
If you have been working on some open issues, and want to include
them in 1.8, please rely this email and let us know the JIRAs number
and corresponding pull requests.
Based on the response, we may go through the list of opens JIRAs for
1.8, and come up with a tentatively cut-off date for 1.8 release.
Thanks,
On Tue, Aug 2, 2016 at 2:14 PM, Aditya <ad...@apache.org> wrote:
> +1 for Jinfeng as the RM for 1.8 release.
>
> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
>
>> I'll volunteer to be the release manager for 1.8, if no one else would
>> like to do so.
>>
>>
>>
>>
>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
>> > Hi Everyone,
>> >
>> > I think its time to roll out 1.8. Would any PMC member/committer
>> like
>> > to volunteer to be the release manager?
>> >
>> > Parth
>>
Re: Time for a 1.8 release
Posted by Aditya <ad...@apache.org>.
+1 for Jinfeng as the RM for 1.8 release.
On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <ji...@gmail.com> wrote:
> I'll volunteer to be the release manager for 1.8, if no one else would
> like to do so.
>
>
>
>
> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
> > Hi Everyone,
> >
> > I think its time to roll out 1.8. Would any PMC member/committer
> like
> > to volunteer to be the release manager?
> >
> > Parth
>
Re: Time for a 1.8 release
Posted by Jinfeng Ni <ji...@gmail.com>.
I'll volunteer to be the release manager for 1.8, if no one else would
like to do so.
On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <pa...@apache.org> wrote:
> Hi Everyone,
>
> I think its time to roll out 1.8. Would any PMC member/committer like
> to volunteer to be the release manager?
>
> Parth