[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1026: [WIP] Support `config set backup-dir new-dir`

[GitBox <gi...@apache.org>]

PragmaTwice commented on PR #1026:
URL: https://github.com/apache/incubator-kvrocks/pull/1026#issuecomment-1287676734

   Hi @mapleFU, after a glance, I have two simple ideas:
   1. Could we add a new seperate mutex for directory changing? e.g. `backup_mu` and `backup_dir_mu`.
   2. If we use only one mutex `backup_mu`, could we use `try_lock` on the directory changing? e.g.
   ```
   if(backup_mu.try_lock()) exchange ...
   else report("backuping, cannot change...")
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org