You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/08/08 20:53:23 UTC
[hadoop] branch branch-3.1 updated: HDFS-14693. NameNode should log
a warning when EditLog IPC logger's pending size exceeds limit. Contributed
by Xudong Cao.
This is an automated email from the ASF dual-hosted git repository.
weichiu pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new 0aa847e HDFS-14693. NameNode should log a warning when EditLog IPC logger's pending size exceeds limit. Contributed by Xudong Cao.
0aa847e is described below
commit 0aa847e1585d1396d2713c95e3a37dd6c3605d96
Author: Wei-Chiu Chuang <we...@apache.org>
AuthorDate: Thu Aug 8 13:50:30 2019 -0700
HDFS-14693. NameNode should log a warning when EditLog IPC logger's pending size exceeds limit. Contributed by Xudong Cao.
(cherry picked from commit 6ad9a11494c3aea146d7741bf0ad52ce16ad08e6)
(cherry picked from commit 2f2fa3dad6dc62ad0e415fa7892008d47a31ddb4)
---
.../java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
index 8d3dc42..a0c7e2c 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
@@ -492,6 +492,10 @@ public class IPCLoggerChannel implements AsyncLogger {
Preconditions.checkArgument(size >= 0);
if (queuedEditsSizeBytes + size > queueSizeLimitBytes &&
queuedEditsSizeBytes > 0) {
+ QuorumJournalManager.LOG.warn("Pending edits to " + IPCLoggerChannel.this
+ + " is going to exceed limit size: " + queueSizeLimitBytes
+ + ", current queued edits size: " + queuedEditsSizeBytes
+ + ", will silently drop " + size + " bytes of edits!");
throw new LoggerTooFarBehindException();
}
queuedEditsSizeBytes += size;
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org