You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/17 17:55:43 UTC

[GitHub] [airflow] ianchudson-caribou opened a new pull request #22345: Add shareProcessNamespace for sidecar

ianchudson-caribou opened a new pull request #22345:
URL: https://github.com/apache/airflow/pull/22345


   This change adds the ability to shareProcessNamespace for sidecars.
   The purpose of this change is to have the ability to kill the sidecar when the job is complete.
   
   Use case is in the case of database sidecar use with an external postgres, the proxy stays open after the job completes and prevents the rest of the application from starting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #22345: Add shareProcessNamespace for sidecar

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #22345:
URL: https://github.com/apache/airflow/pull/22345#issuecomment-1073928939


   I think this should be a bit more than just that. I like the feature and where it could be used (killing  side-car isa feature that is missing in K8S), but I think there are multiple side-cars that I might be considered for that change (not sure what others think) so possibly this could be expanded to others. 
   
   For sure it would be great to add an example on how sharedprocessNamespace can be used for that purpose in the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ianchudson-caribou closed pull request #22345: WIP - Add shareProcessNamespace for sidecar

Posted by GitBox <gi...@apache.org>.

ianchudson-caribou closed pull request #22345:
URL: https://github.com/apache/airflow/pull/22345


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ianchudson-caribou commented on pull request #22345: Add shareProcessNamespace for sidecar

Posted by GitBox <gi...@apache.org>.

ianchudson-caribou commented on pull request #22345:
URL: https://github.com/apache/airflow/pull/22345#issuecomment-1074268885


   > I think this should be a bit more than just that. I like the feature and where it could be used (killing side-car isa feature that is missing in K8S), but I think there are multiple side-cars that I might be considered for that change (not sure what others think) so possibly this could be expanded to others.
   > 
   > For sure it would be great to add an example on how sharedprocessNamespace can be used for that purpose in the documentation.
   
   That makes sense. I'll change this to WIP and add. We're currently attempting to do this exact thing via work around since we don't have access to kill the container. We are deploying redis and postgres externally and need the sidecar proxies to work correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22345: Add shareProcessNamespace for sidecar

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #22345:
URL: https://github.com/apache/airflow/pull/22345#issuecomment-1071153408

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22345: Add shareProcessNamespace for sidecar

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #22345:
URL: https://github.com/apache/airflow/pull/22345#issuecomment-1071153408

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org